PROD-2599 Update PC to support hierarchical consent notices + Update all types #5291
+9,532
−622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
August 30, 2024 16:01
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added 2 commits
September 17, 2024 10:23
…-Center-Update-consent-management-screen-to-render-hierarchical-notices
lucanovera
changed the title
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5291/merge
|
| Run status |
|
| Run duration | 00m 40s |
| Commit |
|
| Committer | Lucano Vera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
eastandwestwind
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
This is looking really great @lucanovera !
Let's just confirm with Jack about the toggle functionality, but otherwise we're good to go here
clients/privacy-center/components/consent/PrivacyPolicyLink.tsx
Outdated
Show resolved
Hide resolved
clients/privacy-center/components/consent/notice-driven/NoticeDrivenConsent.tsx
Show resolved
Hide resolved
clients/privacy-center/components/consent/notice-driven/NoticeDrivenConsent.tsx
Show resolved
Hide resolved
added 2 commits
September 24, 2024 13:00
…-Center-Update-consent-management-screen-to-render-hierarchical-notices
Thanks for the review! Jack confirmed the toggle behavior after watching the Loom demo, so we should be good to go. |
eastandwestwind
approved these changes
Sep 24, 2024
lucanovera
deleted the
PROD-2599-Privacy-Center-Update-consent-management-screen-to-render-hierarchical-notices
branch
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Lucano Vera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Implement hierarchical relationships for Privacy Center consent. Update all openapi generated types, fix type issues.
BE branch needed: https://github.com/ethyca/fidesplus/pull/1602
FE admin-ui branch: #5264
Note for reviewer: You'll probably want to ignore the autogenerated types changes that are in the types/models folder. Also you'll see some type fixes, casting, adding ? !. Basically PC was using a set of hardcoded minimal types that were very outdated AND it still supports a "config-file" driven consent that doesn't use the api. The goal was to get everything updated and typescript working, but it will definitely look cleaner once we deprecate the config consent mode.
Code Changes
Screenshots
Steps to Confirm
Admin UI pre-requesites
Privacy Center
Pre-Merge Checklist
CHANGELOG.md