Debugger enhancements #5288
Draft
Debugger enhancements #5288
+66
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
gilluminate
force-pushed
the
gill/debugger-enhancements
branch
3 times, most recently
from
294478d
to
f2c47ff
Compare
gilluminate
force-pushed
the
gill/debugger-enhancements
branch
from
f2c47ff
to
be821be
Compare
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5288/merge
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
The way our current debugger is working, we lose the originating file and line number from the original call. By bumping the called function into the global scope, it behaves like a normal log but with the added benefit of only working in debug mode. These changes support both the browser and nodejs environments by adding
globalas a child ofwindow, mimicking the global of node. This is how other frameworks have accomplished this (eg. Angular) and is not an uncommon practice.Code Changes
fidesLoggerto the global scope as a conditionalglobalas a child ofwindowdebugLogwithglobal.fidesLogger(named to avoid conflicts)debugLogSteps to Confirm
debugLogwas set.Pre-Merge Checklist
CHANGELOG.md