PROD-2709 Fix Email Connector logs so they use configuration key instead of name #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5286/merge
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | erosselli |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
pattisdr
reviewed
Sep 16, 2024
pattisdr
reviewed
Sep 17, 2024
Comment on lines
309
to
313
| "dataset_name": self.configuration.name | ||
| or self.configuration.key, | ||
| "privacy_request_id": privacy_request.id, | ||
| "collection_name": self.configuration.name, | ||
| "collection_name": self.configuration.name | ||
| or self.configuration.key, |
There was a problem hiding this comment.
a few more places where you can use your new property!
pattisdr
reviewed
Sep 17, 2024
Comment on lines
120
to
124
| "connection_key": self.configuration.key, | ||
| "dataset_name": self.configuration.name, | ||
| "collection_name": self.configuration.name, | ||
| "dataset_name": self.configuration.name | ||
| or self.configuration.key, | ||
| "collection_name": self.configuration.name | ||
| or self.configuration.key, |
erosselli
force-pushed
the
PROD-2709
branch
from
7bc68b0
to
08fe2e5
Compare
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | erosselli |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Vagoasdf
pushed a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2709
Description Of Changes
Adds the
name_or_keyproperty toConnectionConfig, and updates all email connectors to do two things:ExecutionLoginstances created will use thename_or_keyproperty instead of just the nameThis is because the
nameis an optional property for the connection config.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works