Skip to content

Commit

Permalink
Removes the Dynamic Erasure Email connector from sample project (#5287)
Browse files Browse the repository at this point in the history
  • Loading branch information
erosselli committed Sep 16, 2024
1 parent a1ce570 commit a83ad23
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 36 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,3 @@ connection:
dbname: $FIDES_DEPLOY__CONNECTORS__POSTGRES__DBNAME
username: $FIDES_DEPLOY__CONNECTORS__POSTGRES__USERNAME
password: $FIDES_DEPLOY__CONNECTORS__POSTGRES__PASSWORD
- key: cookie_house_dynamic_email_erasure_connector
name: Dynamic Email Erasure Connector
connection_type: dynamic_erasure_email
access: write
system_key: cookie_house_dynamic_email_erasure_system
secrets:
third_party_vendor_name:
dataset: postgres_example_custom_request_field_dataset
field: dynamic_email_address_config.vendor_name
recipient_email_address:
dataset: postgres_example_custom_request_field_dataset
field: dynamic_email_address_config.email_address
test_email_address: test@test.com
17 changes: 0 additions & 17 deletions src/fides/data/sample_project/sample_resources/sample_systems.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,20 +95,3 @@ system:
- customer
dataset_references:
- postgres_example_custom_request_field_dataset

- fides_key: cookie_house_dynamic_email_erasure_system
name: Cookie House Dynamic Email Erasure
description: Connector for erasure request emails with dynamic email addresses
system_type: Application
administrating_department: Engineering
egress:
- fides_key: cookie_house
type: system
privacy_declarations:
- data_categories:
- system
data_use: essential.service
data_subjects:
- customer
dataset_references:
- postgres_example_custom_request_field_dataset
9 changes: 3 additions & 6 deletions tests/ctl/api/test_seed.py
Original file line number Diff line number Diff line change
Expand Up @@ -494,17 +494,16 @@ async def test_load_samples(
dataset_configs = (
(await async_session.execute(select(DatasetConfig))).scalars().all()
)
assert len(systems) == 7
assert len(systems) == 6
assert len(datasets) == 5
assert len(policies) == 1
assert len(connections) == 5
assert len(connections) == 4
assert len(dataset_configs) == 4

assert sorted([e.fides_key for e in systems]) == [
"cookie_house",
"cookie_house_custom_request_fields_database",
"cookie_house_customer_database",
"cookie_house_dynamic_email_erasure_system",
"cookie_house_loyalty_database",
"cookie_house_marketing_system",
"cookie_house_postgresql_database",
Expand All @@ -524,7 +523,6 @@ async def test_load_samples(
assert sorted([e.key for e in connections]) == [
"cookie_house_custom_request_fields_database",
"cookie_house_customer_database_mongodb",
"cookie_house_dynamic_email_erasure_connector",
"cookie_house_postgresql_database",
"stripe_connector",
]
Expand Down Expand Up @@ -600,11 +598,10 @@ async def test_load_sample_connections(self):
assert False, error_message

# Assert that only the connections with all their secrets are returned
assert len(connections) == 5
assert len(connections) == 4
assert sorted([e.key for e in connections]) == [
"cookie_house_custom_request_fields_database",
"cookie_house_customer_database_mongodb",
"cookie_house_dynamic_email_erasure_connector",
"cookie_house_postgresql_database",
"stripe_connector",
]
Expand Down

0 comments on commit a83ad23

Please sign in to comment.