Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

evm: Change Executive::m_gas to int64_t #5317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

evm: Change Executive::m_gas to int64_t #5317

wants to merge 1 commit into from

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 15, 2018

A small follow up for #5316.
A lot more changes like that can be made. If I have time I can push more to this branch. So for, please review.

/// The amount of gas for EVM execution.
///
/// Initial amount before go() execution, the amount of gas left after go() execution.
int64_t m_gas = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what is the advantage of using signed instead of unsigned here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gumb0
Copy link
Member

gumb0 commented Oct 16, 2018

Some SSTORE tests need updating

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants