interop: logindex wildcard and intents #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
Apr 7, 2024
|
|
||
| The author of an executing-transaction may defer the specification of an exact `logIndex` to the block-builder. | ||
| Deferring the `logIndex` enables the executing side to request a message to be initiated. | ||
| The `logIndex` value of `0x01000000000000000000000000000000000000000000000000000000000000` functions as wildcard. |
There was a problem hiding this comment.
This value is only 31 bytes long which I suspect is a typo?
Also how was this value chosen? It doesn't seem very unique, perhaps using bytes32(uint256(keccak256("interop.logIndexWildcard")) - 1) is safer (this is the same ERC-1967 slot computation pattern used in contracts). Or even just converting a string like "interop log index wildcard" to hex and padding it
mds1
reviewed
Apr 7, 2024
| The block-builder is responsible for mapping the wildcard `logIndex` to a valid `logIndex` by appending | ||
| it to a list of indices, declared statically in the input data of the last transaction of the block. | ||
|
|
||
| This declaring transaction must have a `to` address of `0x42ff000000000000000000000000000000000000`. |
There was a problem hiding this comment.
We should have an autogenerated specs page that documents all arbitrary addresses in the 0x42 namespace, or some CI check, to avoid collisions
Edit: probably easier to maintain this manually, and have the CI check ensure that all 0x42 addresses show up on the page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logindex-wildcard for
Identifierto not pre-commit to the consumed event being present in a specific place. This allows the block-builder to complete the static declaration of the event.This is a building block for intents.