fix(list-totalcost): Add l1Cost instead of transaction cost
#324
Conversation
…calculating `l.totalcost`.
|
does it require a hard fork ? |
|
No, I don't believe so. It only affects wheter a transaction enters a mempool or not. Since |
|
@tynes When you have a moment, could you please review this PR? I believe it's affecting the UX, as some of the transactions could be falsely rejected when entering the mempool. |
|
@sebastianst, @geoknee, pinging you both as @tynes seems to be occupied. |
| @@ -344,6 +344,10 @@ func (l *list) Add(tx *types.Transaction, priceBump uint64, l1CostFn txpool.L1Co | |||
| l.totalcost.Add(l.totalcost, cost) | |||
| if l1CostFn != nil { | |||
| if l1Cost := l1CostFn(tx.RollupCostData()); l1Cost != nil { // add rollup cost | |||
| cost, overflow := uint256.FromBig(l1Cost) | |||
There was a problem hiding this comment.
Should this be modifying line 351 to be l.totalcost.Add(l.totalcost, l1Cost) ?
There was a problem hiding this comment.
Unfortunately, this doesn't work because typeOf(l1Cost) = *big.Int and typeOf(l1.totalcost) = *uint256.Int. Consequently, I referred to lines 340-344 to implement the l1Cost cast from *big.Int to *uint256.Int.
The variable cost in this fix holds the intermediate value of l1Cost as *uint256.Int, allowing it to be added to l1.totalcost on line 351.
Description
Previously,
l.totalcostwas calculated incorrectly. The transactioncostwas added twice, and thel1Costwas left out.This PR fixes the sum calculation so that it is correctly calculated as
tx.Cost() + l1Cost.