Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change package name for tools and remove unnecessary doc.go #18607

Closed
wants to merge 1 commit into from

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Sep 19, 2024

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@ahrtr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify 4b9b382 link true /test pull-etcd-verify
pull-etcd-unit-test-386 4b9b382 link true /test pull-etcd-unit-test-386
pull-etcd-unit-test-arm64 4b9b382 link true /test pull-etcd-unit-test-arm64
pull-etcd-unit-test-amd64 4b9b382 link true /test pull-etcd-unit-test-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ahrtr
Copy link
Member Author

ahrtr commented Sep 19, 2024

The libs.go and tools.go have build constraint like //go:build tools, so the pull-etcd-verify still complains context loading failed: no go files to analyze even after changing the packages.

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/etcd-io_etcd/18607/pull-etcd-verify/1836702520009822208

So we can't remove the doc.go file.

@ahrtr ahrtr closed this Sep 19, 2024
@ahrtr ahrtr deleted the tool_20240919 branch September 19, 2024 09:54
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (9fc3b2a) to head (b3ba130).

Current head b3ba130 differs from pull request most recent head 4b9b382

Please upload reports for the commit 4b9b382 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 16 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18607      +/-   ##
==========================================
- Coverage   68.79%   68.75%   -0.05%     
==========================================
  Files         420      420              
  Lines       35519    35519              
==========================================
- Hits        24437    24422      -15     
- Misses       9655     9670      +15     
  Partials     1427     1427              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc3b2a...4b9b382. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants