Commitment: partial unfold #11546
Open
Commitment: partial unfold #11546
+1,062
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 62ed361.
Added debug env `KV_READ_METRICS=false`. When it's true, we gather
Summaries of:
```
kv_get{level="L0"`}
kv_get{level="L1"`}
kv_get{level="L2"`}
kv_get{level="L3"`}
kv_get{level="L4"`}
kv_get{level="recent"}
its a first step to #10691.
Have to add per-domain metrics as well.
I will cover grafana dashboard a bit later.
|
tests failing because of race introduced with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take2 on #11536 #11350
that is final branch with stable account load skipping
i removed counter inside sharedDomainsCommitmentContext and other debug stuff