Merge pull request #45 from uswitch/slashes-are-valid-in-keys

LabelSelector should support / chars in keys
ericchiang · Apr 20, 2017 · 929412d · 929412d
2 parents c43ac68 + 8e3f6e1
commit 929412d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/labels.go b/labels.go
@@ -7,7 +7,7 @@ import (
 
 const (
 	qnameCharFmt           string = "[A-Za-z0-9]"
-	qnameExtCharFmt        string = "[-A-Za-z0-9_.]"
+	qnameExtCharFmt        string = "[-A-Za-z0-9_./]"
 	qualifiedNameFmt       string = "(" + qnameCharFmt + qnameExtCharFmt + "*)?" + qnameCharFmt
 	qualifiedNameMaxLength int    = 63
 	labelValueFmt          string = "(" + qualifiedNameFmt + ")?"

diff --git a/labels_test.go b/labels_test.go
@@ -13,6 +13,12 @@ func TestLabelSelector(t *testing.T) {
 			},
 			want: "component=frontend",
 		},
+		{
+			f: func(l *LabelSelector) {
+				l.Eq("kubernetes.io/role", "master")
+			},
+			want: "kubernetes.io/role=master",
+		},
 		{
 			f: func(l *LabelSelector) {
 				l.In("type", "prod", "staging")