Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pip wheel with Dakota+Carolina #57

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Make pip wheel with Dakota+Carolina #57

merged 1 commit into from
Oct 31, 2023

Conversation

yngve-sk
Copy link

@yngve-sk yngve-sk commented Oct 16, 2023 •
edited
Loading

Resolves #27

@yngve-sk yngve-sk force-pushed the docker-carolina-build-ynk-try2 branch 30 times, most recently from 6a8dc8f to f3e4d0d Compare October 17, 2023 07:37
@yngve-sk yngve-sk force-pushed the docker-carolina-build-ynk-try2 branch 3 times, most recently from 282548f to 7fa7801 Compare October 25, 2023 08:42
andreas-el
andreas-el requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove file not intended to be part of the PR

dakota_manylinux_install_files/DakotaFindPython.cmake Outdated Show resolved Hide resolved
dakota_manylinux_install_files/CMakeLists.txt Outdated Show resolved Hide resolved
andreas-el
andreas-el reviewed Oct 25, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
andreas-el
andreas-el reviewed Oct 25, 2023
View reviewed changes
dakota_manylinux_install_files/build_wheels_gha.sh
export LD_LIBRARY_PATH="/usr/lib:/usr/lib64:$INSTALL_DIR/lib:$INSTALL_DIR/bin:$numpy_lib_dir:$NUMPY_INCLUDE_PATH"
export CMAKE_LIBRARY_PATH=$(echo $LD_LIBRARY_PATH | sed 's/::/:/g' | sed 's/:/;/g')
export PYTHON_LIBRARIES="/usr/lib64/"
export PYTHON_INCLUDE_DIR="/opt/_internal/cpython-3.7.17/include/python3.7m"
Copy link
Contributor

@andreas-el andreas-el Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might cause some issues, no? 3.7.17 is probably not correct for all versions

Copy link
Author

@yngve-sk yngve-sk Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, though it is only used for the python development headers. This was done before finding the .tar with the headers in the manylinux image, so this might be possible to remove without breaking the build, will try it.

Currently this is being run to put the dev headers back, which I think should be for every version.
pushd /opt/_internal && tar -xJf static-libs-for-embedding-only.tar.xz && popd

related manylinux PR: pypa/manylinux#1250

@yngve-sk yngve-sk force-pushed the docker-carolina-build-ynk-try2 branch from dde030b to d382a6b Compare October 25, 2023 12:20
@andreas-el andreas-el force-pushed the docker-carolina-build-ynk-try2 branch 2 times, most recently from a7e5f8c to 480994f Compare October 25, 2023 13:50
@yngve-sk yngve-sk force-pushed the docker-carolina-build-ynk-try2 branch from 34a23c3 to e2be00f Compare October 26, 2023 13:00
@sondreso
Copy link

Could you also change the README with updated install instructions? Currently on PyPi it looks a bit weird since the install instructions are essentially the "Development install instructions". Could you split it into two sections one installation where its essentially pip install carolina and another section with "developing" instructions? (similar to ert) 🙂

@yngve-sk yngve-sk force-pushed the docker-carolina-build-ynk-try2 branch 2 times, most recently from c976fd6 to 786b30a Compare October 27, 2023 07:04
andreas-el
andreas-el requested changes Oct 31, 2023
View reviewed changes
dakota_manylinux_install_files/build_wheels_gha.sh Show resolved Hide resolved
dakota_manylinux_install_files/build_wheels_gha.sh Outdated Show resolved Hide resolved
dakota_manylinux_install_files/CMakeLists.txt Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@yngve-sk yngve-sk force-pushed the docker-carolina-build-ynk-try2 branch from 0851a77 to e6b1f62 Compare October 31, 2023 11:04
andreas-el
andreas-el approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to go! 🚀

@yngve-sk yngve-sk force-pushed the docker-carolina-build-ynk-try2 branch from e6b1f62 to 338aa5b Compare October 31, 2023 11:23
@yngve-sk yngve-sk merged commit 221e366 into main Oct 31, 2023
6 checks passed
@yngve-sk yngve-sk mentioned this pull request Oct 31, 2023
Closed
4 tasks
@oysteoh oysteoh deleted the docker-carolina-build-ynk-try2 branch October 31, 2023 12:36
This was referenced Nov 20, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-el andreas-el andreas-el approved these changes

Assignees

@yngve-sk yngve-sk

Labels
None yet
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundle Dakota with Carolina and make it pip installable
3 participants
@yngve-sk @sondreso @andreas-el