Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test delocate issue #105

Closed
wants to merge 3 commits into from
Closed

Test delocate issue #105

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0376d58
Specify MACOSX_DEPLOYMENT_TARGET for all releases
andreas-el Apr 9, 2024
131b59d
Test with old delocate
andreas-el Apr 9, 2024
4afbc16
otool dylibs
andreas-el Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/bundle_with_dakota_macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,14 +224,16 @@ jobs:
# hint regarding architecture to avoid universal wheel generated
export _PYTHON_HOST_PLATFORM="macosx-11.0-$arch_ver"
export ARCHFLAGS="-arch $arch_ver"

export MACOSX_DEPLOYMENT_TARGET="11.0"
target_version=$(sw_vers --productVersion | cut -d . -f 1)

# the arm64 builds require deployment targets >= 13.0
if [ "$arch_ver" == "arm64" ]; then
export MACOSX_DEPLOYMENT_TARGET="${target_version}.0"
fi

echo "$MACOSX_DEPLOYMENT_TARGET" >> $GITHUB_STEP_SUMMARY

pip install delocate==0.10.7
python -m pip install .
PYTHON_VERSION_TRIM=$(echo ${{ matrix.python-version }} | tr -d ".")
Expand Down Expand Up @@ -282,6 +284,13 @@ jobs:
# ref issue: https://github.com/pypa/cibuildwheel/issues/816
EXTENDED_DYLD_LIBRARY_PATH="${libgccpath}:${HOME}/${INSTALL_DIR}/lib:$INSTALL_DIR/bin"
DYLD_LIBRARY_PATH=${EXTENDED_DYLD_LIBRARY_PATH} delocate-listdeps $unfixed_wheel_path

echo "Done"

DYLD_LIBRARY_PATH=${EXTENDED_DYLD_LIBRARY_PATH} delocate-listdeps $unfixed_wheel_path | otool -l

echo "Delocating wheel .."

DYLD_LIBRARY_PATH=${EXTENDED_DYLD_LIBRARY_PATH} delocate-wheel -w /tmp/carolina_dist -v $unfixed_wheel_path
echo "Output new carolina wheel to /tmp/carolina_dist"
ls -lh /tmp/carolina_dist
Expand Down
Loading