Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upd: update policy 369 to be supported by open source Cloud Custodian #182

Merged
merged 2 commits into from
Sep 23, 2024
Merged

upd: update policy 369 to be supported by open source Cloud Custodian #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5b7b3c
upd: update policy 369 to be supported by open source Cloud Custodian
anna-shcherbak Sep 23, 2024
39020b3
upd: update 'comment' for policy 602
anna-shcherbak Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions non-compatible/policies/ecc-aws-369-workspaces_cloudwatch_integration.yml
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions ...tests/ecc-aws-369-workspaces_cloudwatch_integration/placebo-green/events.ListRules_1.json
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions ...e/tests/ecc-aws-369-workspaces_cloudwatch_integration/placebo-red/events.ListRules_1.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions non-compatible/tests/ecc-aws-369-workspaces_cloudwatch_integration/red_policy_test.py
View file
Open in desktop

This file was deleted.

39 changes: 39 additions & 0 deletions policies/ecc-aws-369-workspaces_cloudwatch_integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Copyright (c) 2023 EPAM Systems, Inc.
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

policies:
- name: ecc-aws-369-workspaces_cloudwatch_integration
comment: '010019123100'
description: |
CloudWatch Events is not set up for successful logins to WorkSpaces
resource: account
filters:
- not:
- type: missing
policy:
resource: workspaces
- type: missing
policy:
resource: aws.event-rule
filters:
- type: value
key: EventPattern
value: not-null
- type: value
key: from_json(EventPattern)."source"
op: in
value_type: swap
value: "aws.workspaces"
- or:
- type: value
key: from_json(EventPattern)."detail-type"
op: in
value_type: swap
value: "WorkSpaces Access"
- type: value
key: from_json(EventPattern)."detail-type"
value: absent

2 changes: 1 addition & 1 deletion policies/ecc-aws-602-cloudwatch_logs_with_no_log_retention_period.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

policies:
- name: ecc-aws-602-cloudwatch_logs_with_no_log_retention_period
comment: '010009012000'
comment: '010001012000'
description: |
CloudWatch Log Group does not have retention period
resource: log-group
Expand Down
2 changes: 1 addition & 1 deletion terraform/ecc-aws-369-workspaces_cloudwatch_integration/green/provider.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 4"
version = "~> 5"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion terraform/ecc-aws-369-workspaces_cloudwatch_integration/green1/provider.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 4"
version = "~> 5"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion terraform/ecc-aws-369-workspaces_cloudwatch_integration/red/provider.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 4"
version = "~> 5"
}
}
}
Expand Down
15 changes: 15 additions & 0 deletions tests/ecc-aws-369-workspaces_cloudwatch_integration/placebo-green/events.ListRules_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"status_code": 200,
"data": {
"Rules": [
{
"Name": "369_cloudwatch_rule_green",
"Arn": "arn:aws:events:us-east-1:111111111111:rule/369_cloudwatch_rule_green",
"EventPattern": "{\"detail-type\":[\"WorkSpaces Access\"],\"source\":[\"aws.workspaces\"]}",
"State": "ENABLED",
"EventBusName": "default"
}
],
"ResponseMetadata": {}
}
}
2 changes: 1 addition & 1 deletion ...placebo-red/iam.ListAccountAliases_1.json → ...acebo-green/iam.ListAccountAliases_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"status_code": 200,
"data": {
"AccountAliases": [
"epmcsec-lab10"
"test"
],
"IsTruncated": false,
"ResponseMetadata": {}
Expand Down
22 changes: 22 additions & 0 deletions ...s/ecc-aws-369-workspaces_cloudwatch_integration/placebo-green/tagging.GetResources_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"status_code": 200,
"data": {
"PaginationToken": "",
"ResourceTagMappingList": [
{
"ResourceARN": "arn:aws:workspaces:us-east-1:111111111111:workspace/ws-3zwmywlx2",
"Tags": [
{
"Key": "ComplianceStatus",
"Value": "Green"
},
{
"Key": "CustodiaRule",
"Value": "ecc-aws-541-workspaces_cloudwatch_integration"
}
]
}
],
"ResponseMetadata": {}
}
}
22 changes: 22 additions & 0 deletions ...s/ecc-aws-369-workspaces_cloudwatch_integration/placebo-green/tagging.GetResources_2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"status_code": 200,
"data": {
"PaginationToken": "",
"ResourceTagMappingList": [
{
"ResourceARN": "arn:aws:events:us-east-1:111111111111:rule/369_cloudwatch_rule_green",
"Tags": [
{
"Key": "ComplianceStatus",
"Value": "Green"
},
{
"Key": "CustodiaRule",
"Value": "ecc-aws-541-workspaces_cloudwatch_integration"
}
]
}
],
"ResponseMetadata": {}
}
}
18 changes: 11 additions & 7 deletions ...-red/workspaces.DescribeWorkspaces_1.json → ...reen/workspaces.DescribeWorkspaces_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,24 @@
"data": {
"Workspaces": [
{
"WorkspaceId": "ws-2kl4hch4j",
"DirectoryId": "d-90674cc9a1",
"WorkspaceId": "ws-3zwmywlx2",
"DirectoryId": "d-9067d5a5a6",
"UserName": "Administrator",
"IpAddress": "10.0.1.215",
"State": "STOPPED",
"IpAddress": "10.0.1.117",
"State": "AVAILABLE",
"BundleId": "wsb-8pmj7b7pq",
"SubnetId": "subnet-014f50caf7d83d8f2",
"ComputerName": "A-346MMO8DR51LL",
"SubnetId": "subnet-066f3d1d03",
"ComputerName": "A-3IONU2C6Z2WZY",
"WorkspaceProperties": {
"RunningMode": "AUTO_STOP",
"RunningModeAutoStopTimeoutInMinutes": 60,
"RootVolumeSizeGib": 80,
"UserVolumeSizeGib": 10,
"ComputeTypeName": "STANDARD"
"ComputeTypeName": "STANDARD",
"Protocols": [
"PCOIP"
],
"OperatingSystemName": "AMAZON_LINUX_2"
},
"ModificationStates": []
}
Expand Down
15 changes: 15 additions & 0 deletions tests/ecc-aws-369-workspaces_cloudwatch_integration/placebo-red/events.ListRules_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"status_code": 200,
"data": {
"Rules": [
{
"Name": "369_cloudwatch_rule_red",
"Arn": "arn:aws:events:us-east-1:111111111111:rule/369_cloudwatch_rule_red",
"EventPattern": "{\"source\":[\"aws.appflow\"],\"detail-type\":[\"AppFlow Start Flow Run Report\"]}",
"State": "ENABLED",
"EventBusName": "default"
}
],
"ResponseMetadata": {}
}
}
2 changes: 1 addition & 1 deletion ...acebo-green/iam.ListAccountAliases_1.json → ...placebo-red/iam.ListAccountAliases_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"status_code": 200,
"data": {
"AccountAliases": [
"epmcsec-lab10"
"test"
],
"IsTruncated": false,
"ResponseMetadata": {}
Expand Down
22 changes: 22 additions & 0 deletions tests/ecc-aws-369-workspaces_cloudwatch_integration/placebo-red/tagging.GetResources_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"status_code": 200,
"data": {
"PaginationToken": "",
"ResourceTagMappingList": [
{
"ResourceARN": "arn:aws:workspaces:us-east-1:111111111111:workspace/ws-3zwmywlx2",
"Tags": [
{
"Key": "ComplianceStatus",
"Value": "Red"
},
{
"Key": "CustodiaRule",
"Value": "ecc-aws-541-workspaces_cloudwatch_integration"
}
]
}
],
"ResponseMetadata": {}
}
}
22 changes: 22 additions & 0 deletions tests/ecc-aws-369-workspaces_cloudwatch_integration/placebo-red/tagging.GetResources_2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"status_code": 200,
"data": {
"PaginationToken": "",
"ResourceTagMappingList": [
{
"ResourceARN": "arn:aws:events:us-east-1:111111111111:rule/369_cloudwatch_rule_red",
"Tags": [
{
"Key": "ComplianceStatus",
"Value": "Red"
},
{
"Key": "CustodiaRule",
"Value": "ecc-aws-541-workspaces_cloudwatch_integration"
}
]
}
],
"ResponseMetadata": {}
}
}
18 changes: 11 additions & 7 deletions ...reen/workspaces.DescribeWorkspaces_1.json → ...-red/workspaces.DescribeWorkspaces_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,24 @@
"data": {
"Workspaces": [
{
"WorkspaceId": "ws-2kl4hch4j",
"DirectoryId": "d-90674cc9a1",
"WorkspaceId": "ws-3zwmywlx2",
"DirectoryId": "d-9067d5a5a6",
"UserName": "Administrator",
"IpAddress": "10.0.1.215",
"State": "STOPPED",
"IpAddress": "10.0.1.117",
"State": "AVAILABLE",
"BundleId": "wsb-8pmj7b7pq",
"SubnetId": "subnet-014f50caf7d83d8f2",
"ComputerName": "A-346MMO8DR51LL",
"SubnetId": "subnet-0775dd66f3d1d0c93",
"ComputerName": "A-3IONU2C6Z2WZY",
"WorkspaceProperties": {
"RunningMode": "AUTO_STOP",
"RunningModeAutoStopTimeoutInMinutes": 60,
"RootVolumeSizeGib": 80,
"UserVolumeSizeGib": 10,
"ComputeTypeName": "STANDARD"
"ComputeTypeName": "STANDARD",
"Protocols": [
"PCOIP"
],
"OperatingSystemName": "AMAZON_LINUX_2"
},
"ModificationStates": []
}
Expand Down
12 changes: 12 additions & 0 deletions tests/ecc-aws-369-workspaces_cloudwatch_integration/red_policy_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import json
class PolicyTest(object):

def test_resources_with_client(self, base_test, resources, local_session):
base_test.assertEqual(len(resources), 1)
rules = local_session.client("events").list_rules()
pattern=json.loads(rules['Rules'][0]['EventPattern'])
base_test.assertNotEqual(pattern["detail-type"], "WorkSpaces Access")
base_test.assertNotEqual(pattern["source"], "aws.workspaces")
workspaces=local_session.client("workspaces").describe_workspaces().get("Workspaces",[])
base_test.assertNotEqual(len(workspaces), 0)