fix: delete files #985
Open
fix: delete files #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ervandagadzhanyan
force-pushed
the
fix-delete-files
branch
from
34662a5
to
eebd1a7
Compare
cakeinsauce
reviewed
Oct 2, 2024
| @@ -7,6 +7,7 @@ | |||
| import minio | |||
| import sqlalchemy.orm | |||
| import sqlalchemy_filters.exceptions | |||
| from badgerdoc_storage.storage import get_storage | |||
There was a problem hiding this comment.
import the storage instead of a dedicated function, please
cakeinsauce
reviewed
Oct 2, 2024
assets/assets/utils/minio_utils.py
Outdated
Comment on lines
249
to
253
| except NotImplementedError as e: | ||
| logger_.error(f"{storage.__class__}.remove: {e}") | ||
| return False |
There was a problem hiding this comment.
I dont think we need it here
cakeinsauce
reviewed
Oct 2, 2024
assets/assets/utils/minio_utils.py
Outdated
| @@ -236,15 +236,19 @@ def upload_thumbnail( | |||
| return True | |||
|
|
|||
|
|
|||
| def delete_one_from_minio(bucket: str, obj: str, client: minio.Minio) -> bool: | |||
| def delete_one_from_minio( | |||
There was a problem hiding this comment.
could you rename it to something more generic, considering the fact we are not linked to minio
ervandagadzhanyan
force-pushed
the
fix-delete-files
branch
3 times, most recently
from
3f3be1e
to
cfa3576
Compare
ervandagadzhanyan
force-pushed
the
fix-delete-files
branch
from
97af944
to
a6978b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.