Skip to content

Commit

Permalink
fixed types
Browse files Browse the repository at this point in the history
  • Loading branch information
aazaliyaa committed Sep 24, 2024
1 parent e026683 commit 37e7050
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion web/src/api/hooks/jobs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export type JobVariables = {
files?: string[] | number[] | null;
previous_jobs?: number[] | null;
datasets?: number[] | null;
revisions?: number[] | string[] | null;
revisions?: string[] | null;
pipeline_name?: string | undefined;
pipeline_id?: number;
pipeline_engine?: string;
Expand Down
2 changes: 1 addition & 1 deletion web/src/api/hooks/revisions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function revisionsFetcher(
filters.push({
field: 'revision',
operator: Operators.ILIKE,
value: `%${searchText.trim().toLowerCase()}%`
value: `%${searchText.trim()}%`
});
}
const body: SearchBody<Revision> = {
Expand Down
2 changes: 1 addition & 1 deletion web/src/api/typings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export type Dataset = {
export type Revision = {
revision: string;
date: string;
id: string | number;
id: string;
};

export type Preprocessor = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ type EditJobConnectorProps = {
files?: number[] | null;
jobs?: number[] | null;
datasets?: number[] | null;
revisions?: number[] | string[] | null;
revisions?: string[] | null;
checkedFiles?: number[];
initialJob?: Job;
showNoExtractionTab?: boolean;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
.title {
padding: 22px 0 12px 0;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ import styles from './revisions-table-connector.module.scss';

type RevisionsTableConnectorProps = {
onRowClick: (id: number | string) => void;
onRevisionSelect?: (revision: number[] | string[]) => void;
checkedValues?: number[] | string[];
onRevisionSelect?: (revision: string[]) => void;
checkedValues?: string[];
};
const size = pageSizes._100;

Expand All @@ -33,7 +33,7 @@ export const RevisionsTableConnector: FC<RevisionsTableConnectorProps> = ({
onRevisionSelect,
checkedValues
}) => {
const [selectedRevisions, setSelectedRevisions] = useState<number[] | string[] | []>([]);
const [selectedRevisions, setSelectedRevisions] = useState<string[] | []>([]);
const {
pageConfig,
onPageChange,
Expand Down Expand Up @@ -67,13 +67,13 @@ export const RevisionsTableConnector: FC<RevisionsTableConnectorProps> = ({
useEffect(() => {
setSelectedRevisions(checked || []);
if (onRevisionSelect) {
onRevisionSelect(checked as number[]);
onRevisionSelect(checked as string[]);
}
}, [checked]);

useEffect(() => {
if (onRevisionSelect) {
onRevisionSelect(selectedRevisions as number[]);
onRevisionSelect(selectedRevisions as string[]);
}
}, [selectedRevisions]);

Expand Down
4 changes: 2 additions & 2 deletions web/src/pages/jobs/edit-job-page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const EditJobPage = () => {
const [files, setFiles] = useState<number[]>([]);
const [jobs, setJobs] = useState<number[]>([]);
const [datasets, setDatasets] = useState<number[]>([]);
const [revisions, setRevivisions] = useState<number[] | string[]>([]);
const [revisions, setRevivisions] = useState<string[]>([]);
const [stepIndex, setStepIndex] = useState(0);
const [currentTab, onCurrentTabChange] = useState('Documents');
const [revisionId, setRevisionId] = useState<string | null>(null);
Expand Down Expand Up @@ -126,7 +126,7 @@ export const EditJobPage = () => {
<RevisionsTableConnector
onRevisionSelect={setRevivisions}
onRowClick={() => null}
checkedValues={datasets}
checkedValues={revisions}
/>
);
}
Expand Down

0 comments on commit 37e7050

Please sign in to comment.