Lms/updated parallel write responses #9393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anathomical
commented
Jul 21, 2022
Comment on lines
-84
to
+90
| activity_session.reload | ||
| expect(activity_session.old_concept_results.size).to eq 7 | ||
| # Run Sidekiq jobs immediately instead of queuing them | ||
| Sidekiq::Testing.inline! do | ||
| expect do | ||
| put :update, params: { id: activity_session.uid, concept_results: concept_results }, as: :json | ||
| end.to change { activity_session.reload.old_concept_results.size }.by(3) | ||
| .and change { activity_session.reload.concept_results.size }.by(3) | ||
| end |
There was a problem hiding this comment.
The original version of those code with expect ... to eq 7 was counting the items that were created as part of setup as well as the ones created by the function call. This cleans things up slightly to only count items new from the call.
brendanshean
approved these changes
Jul 22, 2022
services/QuillLMS/spec/workers/save_activity_session_concept_results_worker_spec.rb
Outdated
Show resolved
Hide resolved
services/QuillLMS/spec/controllers/api/v1/activity_sessions_controller_spec.rb
Show resolved
Hide resolved
emilia-friedberg
approved these changes
Jul 22, 2022
dandrabik
approved these changes
Jul 22, 2022
Don't give it the same name as the original gem's name so that we can avoid confusion
delete-merged-branch
bot
deleted the
lms/updated-parallel-write-responses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Begin writing
ConceptResultrecords whenever we writeOldConceptResultrecords so that both tables keep up to date with any new data from student activitiesWHY
We eventually want to replace
OldConceptResultwithConceptResult, so we need to make sure we can write to both at the same time. Once we're doing that, we can confirm that the data being written is complete in both places to build confidence for a full switch-overHOW
Add a worker that writes
ConceptResultrecords, and enqueue that job during theActivitySessionController'shandle_concept_resultsfunction which is the place where that data gets written.Notion Card Links
https://www.notion.so/quill/Write-Response-records-in-parallel-with-ConceptResults-977206a533da442c9c3cd9fa9ad97be7