Merge pull request #12448 from empirical-org/develop

cleanup all esbuild warnings (#12440)

services/QuillLMS/client/app/bundles/Connect/components/questions/questionForm.jsx

@@ -28,7 +28,6 @@ export default class extends React.Component {
 
     const questionObj = {
       conceptID: concept,
-      cuesLabel: this.props.question.cuesLabel,
       focusPoints: this.props.question.focusPoints,
       incorrectSequences: this.props.question.incorrectSequences,
       modelConceptUID: this.props.question.modelConceptUID,

services/QuillLMS/client/app/bundles/Diagnostic/components/eslDiagnostic/sentenceCombining.jsx

@@ -9,7 +9,6 @@ import { getGradedResponsesWithCallback } from '../../actions/responses.js';
 import { ENGLISH, rightToLeftLanguages } from '../../../Shared/utils/languageList';
 import getResponse from '../renderForQuestions/checkAnswer';
 import RenderQuestionCues from '../renderForQuestions/cues.tsx';
-import RenderFeedback from '../renderForQuestions/feedback';
 import RenderQuestionFeedback from '../renderForQuestions/feedbackStatements.jsx';
 import TextEditor from '../renderForQuestions/renderTextEditor.jsx';
 import { submitQuestionResponse } from '../renderForQuestions/submitResponse.js';
@@ -91,19 +90,6 @@ class ELLSentenceCombining extends React.Component {
     return `${newCues.splice(0, newCues.length - 1).join(', ')} or ${newCues.pop()}.`;
   }
 
-  renderFeedback = () => {
-    const { question, } = this.props
-    return (
-      <RenderFeedback
-        getQuestion={this.getQuestion}
-        listCuesAsString={this.listCuesAsString}
-        question={question}
-        renderFeedbackStatements={this.renderFeedbackStatements}
-        sentence="We have not seen this sentence before. Could you please try writing it in another way?"
-      />
-    );
-  }
-
   getErrorsForAttempt(attempt) {
     return _.pick(attempt, ...C.ERROR_TYPES);
   }

services/QuillLMS/client/app/bundles/Diagnostic/components/questions/questionForm.jsx

@@ -18,7 +18,6 @@ export default class extends React.Component {
   submit = () => {
     const questionObj = {
       conceptUID: this.props.question.conceptUID,
-      cuesLabel: this.props.question.cuesLabel,
       focusPoints: this.props.question.focusPoints,
       incorrectSequences: this.props.question.incorrectSequences,
       modelConceptUID: this.props.question.modelConceptUID,

services/QuillLMS/client/app/bundles/Shared/libs/translations/modules/commonText.js

@@ -27,10 +27,6 @@ export const commonText = {
     header: "You're halfway there!",
     text: "Keep up the great work!"
   },
-  "ELL Halfway": {
-    header: "You're halfway there!",
-    text: "Keep up the great work!"
-  },
   "ELL Starter Questions": {
     header: "Questions",
     text: "In this section, you'll be writing questions. Remember that questions have a question mark (?) at the end. You can do it!"

services/QuillLMS/client/app/bundles/Shared/quill-marking-logic/src/libs/spellchecker/processSentences.ts

@@ -14,7 +14,6 @@ export function processSentences(sentences: string[]): string {
 export function uniqueWordsFromSentences(sentences: string[]): string[] {
   const nestedWords = sentences
     .map(sentence => processSentence(sentence).split('\n')) // process the individual sentences
-    .filter(sentence => sentence !== [] || sentence !== ['']); // remove empty arrays
 
   const flattenedWords: string[] = [].concat.apply([], nestedWords); // flatten the arrays
 

services/QuillLMS/client/app/bundles/Teacher/components/progress_reports/diagnostic_reports/index.jsx

@@ -133,15 +133,6 @@ class DiagnosticReports extends React.Component {
     history.push(`/u/${unitId}/a/${activityId}/c/${classroomId}/student_report/${studentId}/activity_session_id/${value}`)
   }
 
-  changeStudent = (student) => {
-    const { history } = this.props
-    const { value } = student
-    this.setState({selectedStudentId: value })
-    const p = this.parseParams(this.props.location.pathname);
-    const { activityId, classroomId, unitId } = p
-    history.push(`/u/${unitId}/a/${activityId}/c/${classroomId}/student_report/${value}`)
-  };
-
   findClassroomById = (id) => {
     return this.props.classrooms
       ? this.props.classrooms.find((c) => c.id === id)