fix(tagging): query tagging and send session param #1631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(x-installer): update to vue3 and adapt x-installer * feat(x-installer): simplify internal createApp fn * feat(scroll): fix import path * feat(component): keep injector const export * feat(mixins): removing deprecated mixins
BREAKING-CHANGE: refactors the GlobalXBus to use a prop to receive the listeners instead of relying on attributes.
This PR resolves several warnings when running the internal demo app: - Initial warning about overwriting the store modules. - Warnings about `v-on="listeners"` deprecation. - Removal of `v-bind="attrs"` and `inheritAttrs=false`, because Vue3 implemented by default the attributes inheritance. - Fixing warning on `attrs` inheritance in RenderlessFilter. - Fixing some components that throw warnings because the render function was incorrect.
…rective and deprecated layouts (#1576) * get rid of deprecated `MultiColumnMaxWidthLayout` * Revert "get rid of deprecated `MultiColumnMaxWidthLayout`" This reverts commit 7fd0374. * fix(list-components): fix list components, migrate infinite-scroll directive and deprecated layouts * fix(list-components): avoid injecting undefined default value since Vue does it
* refactor(animation-factory): fix Vue3 breaking changes * refactor(animation-factory): await animation to load * refactor(animation-factory): improve type infer * refactor(animations): Vue3 transition class breaking change
* test(components): propsData is now props * test(components): revert skip on test cases * test(components): fix duplicated bus instance * test(components): provide moved inside global property * test(components): remove useless nextTick() * test(components): update jsdoc for installNewXPlugin()
Co-authored-by: Diego Pascual <diegopf@users.noreply.github.com>
…on (#1578) Co-authored-by: Jose A. Cabaneros <joseacabaneros@gmail.com>
Co-authored-by: Diego Pascual <diegopf@users.noreply.github.com>
BREAKING CHANGE: @empathyco/x-archetype-utils is only compatible with vue 3
…1607) Co-authored-by: Víctor CG <victorcg@empathy.co>
BREAKING CHANGE: @empathyco/x-components v6 and @empathyco/x-archetype-utils v2 are only compatible with Vue 3 and if you are looking for the Vue 2 versions, take look at the main brach.
- vue3-migration-test@1.0.0-alpha.51 - @empathyco/x-archetype-utils@2.0.0-alpha.1 - @empathyco/x-components@6.0.0-alpha.1 - @empathyco/x-tailwindcss@1.2.0-alpha.6
* test: fix experience-controls and tagging tests * test: fix scroll module and clear-search-input tests * test:fix related-tag test * test: fix tests in search module * test: fix tests in history-queries module * test: fix x-modules tests * tests: QueryPreview * test: fix semantic queries test * test: fix semantic query test * test: fix x-modules tests * test: query preview button test * test: use queries preview composable * test: queries preview getter * fix e2e tests * fix e2e tests * test: rm unneeded reset in queries preview composable * test: query preview actions test * test: query preview utils test * test: fix x-modules tests * test: fix x-modules tests * test: query preview list test * test: fix facets module tests * test: adjust some filters lists tests * test: facets getter test * test: use-filters-injection composable * test: fix facets module tests * test: test facets-service * test: adapt some filters tests * test: rm localVue from url module's utils * test: fix tagging actions test * test: fix pdp-add-to-cart service * test: fix search button test * test: fix semantics module tests * test: fix experience-controls getter test * test: adjust selected-filters-list test * test: fix getters-proxy.spec.ts * test: fix search input test * test: fix search input placeholder test * test: fix search box module actions test * test: fix facets-provider.spec.ts * test: adjust preselected-filters test * test: fix base-event-button and use-x-bus test sheets * test: fix test sheets of filter components * test: fix highlight and result-variants-provider-and-selector tests --------- Co-authored-by: Diego Pascual <diegopf@users.noreply.github.com> Co-authored-by: albertjcuac <albertjcuac@gmail.com> Co-authored-by: acondal <annac@empathy.co> Co-authored-by: Jose Antonio Cabañeros <joseacabaneros@gmail.com>
BREAKING CHANGE: remove `change` event emission in favour of `update:modelValue` in `BaseSwitch` component.
* test: fix semantic queries test * test: use queries preview composable * fix e2e tests * fix e2e tests * test: rm unneeded reset in queries preview composable * test: fix facets module tests * test: fix semantics module tests * test: wip * test: preselected-filters in progress * test: WIP stopped tests * test: fix test sheets of filter components * test: fix search-input test * test: fix renderless-extra-params test * test: fix clear-history-queries test sheet * test: fix related-tags test sheets * test: fix next-query test * test: fix x-installer test sheet * test: fix default-api test sheet * test: fix test sheets related with vue-global-events third party dependency * test: fix actions test sheet of related-tags module * test: fix identifier-results test sheet * test: fix results-list test sheet and forward slots in the component itself * test: fix banners-list test sheet and forward slots in the component itself * test: fix promoted-list test sheet and forward slots in the component itself * test: fix next-queries test sheet * test: fix selected-filters test sheet * test: fix query-preview test sheet * test: reactivate skipped test in history-query and clean up * fix: PR comments * test: fix search-input unit test * test: fix next-queries-list test sheet * test: fix minor issue with query-preview-list test sheet * test: fix PR comments --------- Co-authored-by: Diego Pascual <diegopf@users.noreply.github.com> Co-authored-by: acondal <annac@empathy.co> Co-authored-by: Laura Martinez Garcia <lauram@empathy.co> Co-authored-by: albertjcuac <albertjcuac@gmail.com>
- @empathyco/x-components@6.0.0-alpha.2
- @empathyco/x-components@6.0.0-alpha.3
lauramargar
deleted the
fix-queryTagging-and-send-session-param-if-consent-is-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring changes to the vue3 branch. (#1627)