Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update prepare release pull request title #1365

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

herrardo
Copy link
Contributor

@herrardo herrardo commented Nov 28, 2023

Pull request template

Change the title of the PR created when the prepare-release action is created

Motivation and context

The title of the PRis used for the stash commit.

When the PR is merged the workflow to create the alpha SHOULD NOT BE FIRED

For that we can do 2 things:

  • Stop the workflow manually to no create the alpha when that PR is merged, which is dangerous because we can forget
  • Change the title of the PR to chore(release): prepare stable release because the alpha release checks that title and stops if the commit contains chore(release)
  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@herrardo herrardo requested a review from a team as a code owner November 28, 2023 12:29
@herrardo herrardo merged commit 783dfd6 into main Dec 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants