Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(device-detector): fix vue live examples for doc portal #1260

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

herrardo
Copy link
Contributor

@herrardo herrardo commented Aug 21, 2023

Pull request template

Change Vue live examples

The current example is not working: https://docs.empathy.co/develop-empathy-platform/ui-reference/components/device/x-components.device-detector.html#see-it-in-action

Check it in the PR preview that I created by syncing Dynamic Dcos:

https://docs-dev.empathy.co/preview/1378/develop-empathy-platform/ui-reference/components/device/x-components.device-detector.html

Motivation and context

Get all vue live examples to work in eDocs

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@herrardo herrardo requested a review from a team as a code owner August 21, 2023 09:24
@mavmaf mavmaf merged commit 546f74e into main Aug 21, 2023
6 checks passed
@diegopf diegopf deleted the doc/fix-device-detector-live-example branch September 6, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants