fix: check if extraParams are really changing

empathyco · Sep 30, 2024 · 97d3e28 · 97d3e28
1 parent 08467db
commit 97d3e28
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/packages/x-components/src/x-modules/extra-params/components/snippet-config-extra-params.vue b/packages/x-components/src/x-modules/extra-params/components/snippet-config-extra-params.vue
@@ -35,16 +35,25 @@
     },
     setup(props) {
       const snippetConfig = inject('snippetConfig') as SnippetConfig;
-      const extraParams = ref({});
+      const extraParams = ref<Record<string, unknown>>({});
+      const initialExtraParams = ref<Record<string, unknown>>({});
 
       watch(
         [() => snippetConfig, () => props.values],
         () => {
+          const newExtraParams: Record<string, unknown> = {};
+
           forEach({ ...props.values, ...snippetConfig }, (name, value) => {
             if (!props.excludedExtraParams.includes(name)) {
-              extraParams.value = { ...extraParams.value, [name]: value };
+              newExtraParams[name] = value;
             }
           });
+
+          // Check if extraParams are really changing to avoid event emission if they don't
+          if (JSON.stringify(newExtraParams) !== JSON.stringify(initialExtraParams.value)) {
+            extraParams.value = newExtraParams;
+            initialExtraParams.value = newExtraParams;
+          }
         },
         {
           deep: true,