Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[un-tested] feat: include storybook-title column during event export #123

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Eunoia1729
Copy link

No description provided.

Copy link
Member

@nya-elimu nya-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace Long with String

Copy link
Member

@nya-elimu nya-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eunoia1729 The app crashes on launch due to a problem with the Room database:

2022-04-20 16:23:22.918 24779-24825/ai.elimu.analytics.debug E/AndroidRuntime: FATAL EXCEPTION: pool-1-thread-1
    Process: ai.elimu.analytics.debug, PID: 24779
    java.lang.IllegalStateException: Room cannot verify the data integrity. Looks like you've changed schema but forgot to update the version number. You can simply fix this by increasing the version number.
        at androidx.room.RoomOpenHelper.checkIdentity(RoomOpenHelper.java:154)
        at androidx.room.RoomOpenHelper.onOpen(RoomOpenHelper.java:135)

This is because we need to bump the @Database(version = 5 to version=6 in RoomDb.java, and add an SQL migration script for the new database column that was added to the StoryBookLearningEvent table.

Then, when you launch the app, a file will be automatically generated at app/schemas/ai.elimu.analytics.db.RoomDb/6.json.

@Eunoia1729
Copy link
Author

This is because we need to bump the @Database(version = 5 to version=6 in RoomDb.java, and add an SQL migration script for the new database column that was added to the StoryBookLearningEvent table.

Sure, done! Kindly re-review when possible

Copy link
Member

@nya-elimu nya-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the new JSON file in schemas/ is missing? It should be auto-generated when launching the app.

@nya-elimu
Copy link
Member

Hi, @Eunoia1729. Do you need help with completing this PR?

@Eunoia1729
Copy link
Author

Hi @nya-elimuai, yes im facing difficulties in setting up the app and launching it.

Thereby, the final step of auto-generating the required json is remaining. Help in this last step would be greatly appreciated.
Thank you

@nya-elimu
Copy link
Member

Hi @nya-elimuai, yes im facing difficulties in setting up the app and launching it.

Thereby, the final step of auto-generating the required json is remaining. Help in this last step would be greatly appreciated. Thank you

@Eunoia1729 All right, sounds good. First, can you apply to this Dework task? (We have migrated from Gitcoin to Dework since last time we spoke.) https://app.dework.xyz/elimuai/android-development?taskId=f28d5a5c-6e5b-4569-a2df-9568098fdb1f

@Eunoia1729
Copy link
Author

Hi @nya-elimuai, yes im facing difficulties in setting up the app and launching it.
Thereby, the final step of auto-generating the required json is remaining. Help in this last step would be greatly appreciated. Thank you

@Eunoia1729 All right, sounds good. First, can you apply to this Dework task? (We have migrated from Gitcoin to Dework since last time we spoke.) https://app.dework.xyz/elimuai/android-development?taskId=f28d5a5c-6e5b-4569-a2df-9568098fdb1f

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants