Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the the type hint for Document.get() #1910

Closed
wants to merge 1 commit into from
Closed

Fixed the the type hint for Document.get() #1910

wants to merge 1 commit into from

Conversation

miguelgrinberg
Copy link
Collaborator

Fixes #1908

@miguelgrinberg miguelgrinberg requested review from pquentin and removed request for pquentin September 11, 2024 19:10
@miguelgrinberg
Copy link
Collaborator Author

Closing as this is actually incorrect. The client can be configured to ignore the 404 error, and in that case the get() method should return None.

@miguelgrinberg miguelgrinberg deleted the fix-type-hint-document-get branch September 11, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document.get() documentation is misleading - not found does not return None
1 participant
@miguelgrinberg