Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added recursive to_dict support to AttrDict #1892

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Added recursive to_dict support to AttrDict #1892

merged 1 commit into from
Sep 3, 2024

Conversation

miguelgrinberg
Copy link
Collaborator

@miguelgrinberg miguelgrinberg commented Aug 30, 2024 •
edited
Loading

Fixes #1520

The AttrDict.to_dict() method now has a recursive flag which defaults to False. If True, all contents of the dict are converted.

@miguelgrinberg miguelgrinberg force-pushed the recursive-to-dict branch 3 times, most recently from 59b119b to a7b6202 Compare August 30, 2024 18:24
@miguelgrinberg miguelgrinberg marked this pull request as ready for review August 30, 2024 18:36
pquentin
pquentin approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Sep 3, 2024
@miguelgrinberg miguelgrinberg merged commit 318ea9a into elastic:main Sep 3, 2024
16 checks passed
@miguelgrinberg miguelgrinberg deleted the recursive-to-dict branch September 3, 2024 09:25
github-actions bot pushed a commit that referenced this pull request Sep 3, 2024
@miguelgrinberg @github-actions
Added recursive to_dict support to AttrDict (#1892)
b0b024a 
Fixes #1520

(cherry picked from commit 318ea9a)
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Merged
miguelgrinberg added a commit that referenced this pull request Sep 3, 2024
@github-actions @miguelgrinberg
Added recursive to_dict support to AttrDict (#1892) (#1894)
7dbf074 
Fixes #1520

(cherry picked from commit 318ea9a)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
backport 8.x Backport to 8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_dict() doesn't convert inner_hits
2 participants
@miguelgrinberg @pquentin