feat: support i18n and rules config #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 1 -2
Lines 9 14 +5
=====================================
+ Hits 9 14 +5
Continue to review full report at Codecov.
|
|
补充了 context 的测试 |
atian25
requested changes
Nov 13, 2017
|
中文部分的测试已经补充 |
atian25
requested changes
Nov 14, 2017
|
我把依赖包升级了一下，测试代码已经改过来了。 |
|
i18n 没有注册 |
|
嗯，所以 validator 目前还是得绑定在 context 中而不是 app 中。这种情况下 this.validator.addRule这个用法好像意义不大。而且只能在 context 中 |
|
嗯，先这样吧，反正原来也是有 cc @eggjs/core 也 Review 下？ |
atian25
requested changes
Nov 16, 2017
|
喔噢
发自我的 iPhone
… 在 2017年11月16日，16:40，cwfan ***@***.***> 写道：
@runfan commented on this pull request.
In config/locales/zh-CN.js:
> @@ -0,0 +1,27 @@
+'use strict';
egg config 下面的文件是会合并的不是吗？我是希望这些翻译直接做为默认的中文翻译放到项目中:)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
那么，我关闭这个 PR 了 |
|
先留着吧，回头我在另一个 PR 中自动 close 也行。 |
|
@atian25 @dead-horse @runfan any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
错误信息输出支持 eggjs 中的 i18n
Description of change
parameter.translate 实现，并且使用 gettext 支持
app.validate 去掉
增加在 config.default 中配置 rules