refactor(rpc): Test and document new top-level question attributes from LimeSurvey 6.6.3 #1189
+45
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1189 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 482 482
Branches 25 25
=========================================
Hits 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
test-new-question-attributes
branch
2 times, most recently
from
bbc6665
to
d598524
Compare
edgarrmondragon
changed the title
edgarrmondragon
force-pushed
the
test-new-question-attributes
branch
from
d598524
to
25d81e2
Compare
edgarrmondragon
changed the title
|
edgarrmondragon
changed the title
coeurdestenebres
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was introduced by LimeSurvey/LimeSurvey@c8df4cb, and will be available starting with LimeSurvey 6.6.3.
This includes the following attributes:
questionhelpscriptquestionl10nsTest Plan
Checklist
For both the title of the PR and the changelog entry, prefer simple past tense or constructions with "now". For example:
Client.invite_participants()Client.user_activation_settings()now accepts auser_activation_settingskeyword argument📚 Documentation preview 📚: https://citric--1189.org.readthedocs.build/en/1189/