Let jobs retweak easyconfigs themselves #4669
Draft
+61
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be accomplished by tweak() optionally also returning a dict which maps the tweaked easyconfig to the original version. Then the job can run `eb ... <original_easyconfig.eb> --try-*` and that original easyconfig will be retweaked in the job itself. If the easyconfig passed to the job is not tweaked, then `--try-*` is *not* passed down (so, with `--robot`, some jobs will have `--try-*` and some don't). This removes the requirement of a shared tmpdir with `--job --try-*`. Fixes easybuilders#1355
|
Putting to draft because this needs a proper test combining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be accomplished by
tweak()optionally also returning a dict which maps the tweaked easyconfig to the original version. Then the job can runeb ... <original_easyconfig.eb> --try-*and that original easyconfig will be retweaked in the job itself.If the easyconfig passed to the job is not tweaked, then
--try-*is not passed down (so, with--robot, some jobs will have--try-*and some don't).This removes the requirement of a shared tmpdir with
--job --try-*.Fixes #1355