Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only call _sanity_check_step_extensions if --skip-extensions is not set #4620

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

Flamefire
Copy link
Contributor

Derived easyblocks might want to override this method to add own checks. By moving the check outside the call it doesn't need to be repeated in derived classes.

Derived easyblocks might want to override this method to add own checks.
By moving the check outside the call it doesn't need to be repeated in
derived classes.
@boegel boegel changed the title only call _sanity_check_step_extensions if --skip-extensions is not set only call _sanity_check_step_extensions if --skip-extensions is not set Sep 7, 2024
@boegel boegel modified the milestones: release after 4.9.3, 4.9.3 Sep 7, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 703d3a1 into easybuilders:develop Sep 7, 2024
37 checks passed
@Flamefire Flamefire deleted the extension-skip branch September 9, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants