-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new get_cwd
function to tools.filetools
to retrieve current working directory
#4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…http_header_fields_urlpat
boegel
requested changes
May 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor suggestions, looks good overall!
boegel
changed the title
add new method tools.filetools.get_cwd to retrieve current working directory
add new May 4, 2024
get_cwd
function to tools.filetools
to retrieve current working directory
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
boegel
requested changes
May 22, 2024
move `CWD_NOTFOUND_ERROR` constant to `tools.build_log`
boegel
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple addition of a wrapper around
os.getcwd
to be able to improve error reporting whenever it fails.This PR includes unit tests for the new method and also adapts all current uses of
os.getcwd
to the newget_cwd
.Motivation is to improve error reporting on issues such as those described in #4390