also consider $EB_COMSOL_LICENSE_FILE environment variable in custom easyblock for COMSOL
#3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
boegel
requested changes
Dec 6, 2023
easybuild/easyblocks/c/comsol.py
Outdated
| @@ -59,7 +59,7 @@ def extract_step(self): | |||
| def configure_step(self): | |||
| """Configure COMSOL installation: create license file.""" | |||
|
|
|||
| default_lic_env_var = 'LMCOMSOL_LICENSE_FILE' | |||
| default_lic_env_var = 'EB_COMSOL_LICENSE_FILE' | |||
There was a problem hiding this comment.
Can't we consider both?
Need to check whether find_flexlm_license considers all variables passed to custom_env_vars (but I think it does)
There was a problem hiding this comment.
i just checked and it does consider all of them indeed. it also considers LM_LICENSE_FILE, but only if custom_env_vars does not yield a valid license.
boegel
changed the title
$EB_COMSOL_LICENSE_FILE variable in custom easyblock for COMSOL
boegel
changed the title
$EB_COMSOL_LICENSE_FILE variable in custom easyblock for COMSOL$EB_COMSOL_LICENSE_FILE environment variable in custom easyblock for COMSOL
boegel
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)I don't know if i really matters if i target this to develop or 5.0 branch. Noone ever merges my COMSOL easyconfigs anyway.