Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable disk space check in STAR-CCM+ installer #2956

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Jul 4, 2023

(created using eb --new-pr)

…t that this makes installer exit with non-zero exit code
@boegel boegel added the bug fix label Jul 5, 2023
@boegel boegel added this to the 4.x milestone Jul 5, 2023
@boegel boegel changed the title disable disk space check in STAR-CCM+ installer, and take into account that this makes installer exit with non-zero exit code disable disk space check in STAR-CCM+ installer Jul 5, 2023
@jfgrimm
Copy link
Member

jfgrimm commented Jul 6, 2023

looks sensible to me
@boegel I don't have a license for STAR-CCM+, can you submit a test report for some versions?

@branfosj
Copy link
Member

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS STAR-CCM+-18.02.008.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/52744112340bdebc202cc5dffc6939cf for a full test report.

@branfosj branfosj modified the milestones: 4.x, next release (4.8.1?) Jul 25, 2023
@branfosj
Copy link
Member

Going in, thanks @boegel!

@branfosj branfosj merged commit 6bad5b0 into easybuilders:develop Jul 25, 2023
46 checks passed
@boegel boegel deleted the 20230704173708_new_pr_star_ccm branch August 1, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants