Upgrade v3 to current geocoder compatibility #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3 #243 +/- ##
=========================================
Coverage 74.31% 74.31%
Complexity 107 107
=========================================
Files 7 7
Lines 366 366
=========================================
Hits 272 272
Misses 94 94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nathanbrauer
commented
Mar 24, 2024
| $lat = $response->getLatitude(); | ||
| $lng = $response->getLongitude(); | ||
| $lat = $response->getCoordinates()->getLatitude(); | ||
| $lng = $response->getCoordinates()->getLongitude(); |
There was a problem hiding this comment.
Although, wouldn't it be more economical to do this instead?
$coordinates = $geocoder->getResult()->getCoordinates();
$lat = $coordinates->getLatitude();
$lng = $coordinates->getLongitude();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed you're working on this at the same time I am - starting a pull request.
FYI - due to several other packages requiring
dynamic/silverstripe-geocoder:^1.0, you may need to run the following until it's safe to upgrade all the others (e.g.core-tools,silverstripe-elemental-customer-service, etc):