Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated out an api controller #192

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Jul 2, 2018

Pulled out methods from the locator controller and one from the locator page.
Mostly for a locator block.

Resolves #109

pulled out methods from the locator controller and one from the locator page.
  - removed old tests for stuff that was moved
Fixed error on getLimit()
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #192 into master will decrease coverage by 1.72%.
The diff coverage is 77.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #192      +/-   ##
============================================
- Coverage     68.67%   66.94%   -1.73%     
- Complexity       90      102      +12     
============================================
  Files             7        8       +1     
  Lines           316      357      +41     
============================================
+ Hits            217      239      +22     
- Misses           99      118      +19
Impacted Files Coverage Δ Complexity Δ
src/Admin/LocationAdmin.php 0% <ø> (ø) 4 <0> (?)
src/Model/LocationCategory.php 100% <ø> (ø) 7 <0> (?)
src/Form/LocatorForm.php 78.94% <ø> (ø) 10 <0> (?)
src/Model/Location.php 100% <ø> (ø) 10 <0> (?)
src/Page/LocatorController.php 9.45% <0%> (ø) 18 <0> (?)
src/Control/APIController.php 85.43% <85.43%> (ø) 34 <34> (?)
src/Page/Locator.php 87.5% <85.71%> (ø) 17 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 142afd7...378db70. Read the comment docs.

@mak001 mak001 removed the Don't Merge label Jul 3, 2018
@mak001 mak001 requested review from jsirish and muskie9 July 3, 2018 20:20
  - added optional request parameter
Copy link
Member

@jsirish jsirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will need a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants