moved env and secret setting

dvsa · May 18, 2024 · d46d8b0 · d46d8b0
1 parent 49aef66
commit d46d8b0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/.github/workflows/cd.yaml b/.github/workflows/cd.yaml
@@ -16,12 +16,11 @@ jobs:
       tag_name: ${{ steps.release.outputs.tag_name }}
       release_created: ${{ steps.release.outputs.release_created }}
     steps:
-      - uses: google-github-actions/release-please-action@v4
+      - uses: googleapis/release-please-action@v4
         id: release
         with:
           release-type: maven
-
-
+
   publish:
     if: ${{needs.release-please.outputs.release_created}}
     runs-on: ubuntu-latest
@@ -43,12 +42,15 @@ jobs:
 
   push:
       if: ${{needs.release-please.outputs.release_created}}
+      permissions:
+        contents: read
+        packages: write
+
       name: Publish to GitHub Packages Apache Maven
       uses: ./.github/workflows/maven.yaml
       with:
         maven-goal: deploy
+
       needs: release-please
-      env:
-        GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
-
+
 
diff --git a/.github/workflows/maven.yaml b/.github/workflows/maven.yaml
@@ -8,13 +8,19 @@ on:
         required: true
         default: 'package'
         type: string
+    secrets:
+      GITHUB_TOKEN:
+        description: 'GitHub token'
+        required: true
 
 permissions:
   contents: read
 
 jobs:
     build:
       name: build
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       runs-on: ubuntu-latest
       steps:
        - uses: actions/checkout@v4