minor(cb2-10521): change adr brake endurance weight unit of measureme…

…nt to tonnes on a technical record (#162) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dvsa · Jan 26, 2024 · ec8585e · ec8585e
1 parent 6217877
commit ec8585e
Show file tree

Hide file tree

Showing 27 changed files with 44 additions and 44 deletions.
diff --git a/json-definitions/v3/tech-record/get/hgv/complete/index.json b/json-definitions/v3/tech-record/get/hgv/complete/index.json
@@ -236,10 +236,10 @@
     },
     "techRecord_adrDetails_weight": {
       "type": [
-        "string",
+        "number",
         "null"
       ],
-      "maxLength": 8
+      "maximum": 99999999
     },
     "techRecord_adrDetails_declarationsSeen": {
       "type": [

diff --git a/json-definitions/v3/tech-record/get/hgv/skeleton/index.json b/json-definitions/v3/tech-record/get/hgv/skeleton/index.json
@@ -206,10 +206,10 @@
     },
     "techRecord_adrDetails_weight": {
       "type": [
-        "string",
+        "number",
         "null"
       ],
-      "maxLength": 8
+      "maximum": 99999999
     },
     "techRecord_adrDetails_declarationsSeen": {
       "type": [

diff --git a/json-definitions/v3/tech-record/get/hgv/testable/index.json b/json-definitions/v3/tech-record/get/hgv/testable/index.json
@@ -210,10 +210,10 @@
     },
     "techRecord_adrDetails_weight": {
       "type": [
-        "string",
+        "number",
         "null"
       ],
-      "maxLength": 8
+      "maximum": 99999999
     },
     "techRecord_adrDetails_declarationsSeen": {
       "type": [

diff --git a/json-definitions/v3/tech-record/get/lgv/complete/index.json b/json-definitions/v3/tech-record/get/lgv/complete/index.json
@@ -241,10 +241,10 @@
     },
     "techRecord_adrDetails_weight": {
       "type": [
-        "string",
+        "number",
         "null"
       ],
-      "maxLength": 8
+      "maximum": 99999999
     },
     "techRecord_adrDetails_declarationsSeen": {
       "type": [

diff --git a/json-definitions/v3/tech-record/get/lgv/skeleton/index.json b/json-definitions/v3/tech-record/get/lgv/skeleton/index.json
@@ -238,10 +238,10 @@
     },
     "techRecord_adrDetails_weight": {
       "type": [
-        "string",
+        "number",
         "null"
       ],
-      "maxLength": 8
+      "maximum": 99999999
     },
     "techRecord_adrDetails_declarationsSeen": {
       "type": [

diff --git a/json-definitions/v3/tech-record/get/trl/complete/index.json b/json-definitions/v3/tech-record/get/trl/complete/index.json
@@ -218,10 +218,10 @@
     },
     "techRecord_adrDetails_weight": {
       "type": [
-        "string",
+        "number",
         "null"
       ],
-      "maxLength": 8
+      "maximum": 99999999
     },
     "techRecord_adrDetails_declarationsSeen": {
       "type": [

diff --git a/json-definitions/v3/tech-record/get/trl/skeleton/index.json b/json-definitions/v3/tech-record/get/trl/skeleton/index.json
@@ -198,10 +198,10 @@
     },
     "techRecord_adrDetails_weight": {
       "type": [
-        "string",
+        "number",
         "null"
       ],
-      "maxLength": 8
+      "maximum": 99999999
     },
     "techRecord_adrDetails_declarationsSeen": {
       "type": [

diff --git a/json-definitions/v3/tech-record/get/trl/testable/index.json b/json-definitions/v3/tech-record/get/trl/testable/index.json
@@ -200,10 +200,10 @@
     },
     "techRecord_adrDetails_weight": {
       "type": [
-        "string",
+        "number",
         "null"
       ],
-      "maxLength": 8
+      "maximum": 99999999
     },
     "techRecord_adrDetails_declarationsSeen": {
       "type": [

diff --git a/json-schemas/v3/tech-record/get/hgv/complete/index.json b/json-schemas/v3/tech-record/get/hgv/complete/index.json
@@ -245,10 +245,10 @@
 		},
 		"techRecord_adrDetails_weight": {
 			"type": [
-				"string",
+				"number",
 				"null"
 			],
-			"maxLength": 8
+			"maximum": 99999999
 		},
 		"techRecord_adrDetails_declarationsSeen": {
 			"type": [

diff --git a/json-schemas/v3/tech-record/get/hgv/skeleton/index.json b/json-schemas/v3/tech-record/get/hgv/skeleton/index.json
@@ -215,10 +215,10 @@
 		},
 		"techRecord_adrDetails_weight": {
 			"type": [
-				"string",
+				"number",
 				"null"
 			],
-			"maxLength": 8
+			"maximum": 99999999
 		},
 		"techRecord_adrDetails_declarationsSeen": {
 			"type": [

diff --git a/json-schemas/v3/tech-record/get/hgv/testable/index.json b/json-schemas/v3/tech-record/get/hgv/testable/index.json
@@ -219,10 +219,10 @@
 		},
 		"techRecord_adrDetails_weight": {
 			"type": [
-				"string",
+				"number",
 				"null"
 			],
-			"maxLength": 8
+			"maximum": 99999999
 		},
 		"techRecord_adrDetails_declarationsSeen": {
 			"type": [

diff --git a/json-schemas/v3/tech-record/get/lgv/complete/index.json b/json-schemas/v3/tech-record/get/lgv/complete/index.json
@@ -250,10 +250,10 @@
 		},
 		"techRecord_adrDetails_weight": {
 			"type": [
-				"string",
+				"number",
 				"null"
 			],
-			"maxLength": 8
+			"maximum": 99999999
 		},
 		"techRecord_adrDetails_declarationsSeen": {
 			"type": [

diff --git a/json-schemas/v3/tech-record/get/lgv/skeleton/index.json b/json-schemas/v3/tech-record/get/lgv/skeleton/index.json
@@ -247,10 +247,10 @@
 		},
 		"techRecord_adrDetails_weight": {
 			"type": [
-				"string",
+				"number",
 				"null"
 			],
-			"maxLength": 8
+			"maximum": 99999999
 		},
 		"techRecord_adrDetails_declarationsSeen": {
 			"type": [

diff --git a/json-schemas/v3/tech-record/get/trl/complete/index.json b/json-schemas/v3/tech-record/get/trl/complete/index.json
@@ -227,10 +227,10 @@
 		},
 		"techRecord_adrDetails_weight": {
 			"type": [
-				"string",
+				"number",
 				"null"
 			],
-			"maxLength": 8
+			"maximum": 99999999
 		},
 		"techRecord_adrDetails_declarationsSeen": {
 			"type": [

diff --git a/json-schemas/v3/tech-record/get/trl/skeleton/index.json b/json-schemas/v3/tech-record/get/trl/skeleton/index.json
@@ -207,10 +207,10 @@
 		},
 		"techRecord_adrDetails_weight": {
 			"type": [
-				"string",
+				"number",
 				"null"
 			],
-			"maxLength": 8
+			"maximum": 99999999
 		},
 		"techRecord_adrDetails_declarationsSeen": {
 			"type": [

diff --git a/json-schemas/v3/tech-record/get/trl/testable/index.json b/json-schemas/v3/tech-record/get/trl/testable/index.json
@@ -209,10 +209,10 @@
 		},
 		"techRecord_adrDetails_weight": {
 			"type": [
-				"string",
+				"number",
 				"null"
 			],
-			"maxLength": 8
+			"maximum": 99999999
 		},
 		"techRecord_adrDetails_declarationsSeen": {
 			"type": [

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@dvsa/cvs-type-definitions",
-  "version": "5.0.0",
+  "version": "5.1.0",
   "description": "type definitions for cvs vta and vtm applications",
   "main": "index.js",
   "repository": {

diff --git a/tests/hgv/skeleton.test.ts b/tests/hgv/skeleton.test.ts
@@ -96,7 +96,7 @@ describe("validate ADR hgv schema", () => {
   it("should pass if techRecord_adrDetails_brakeEndurance is true and weight is present", () => {
     const data = hgvData[7];
     (data as any).techRecord_adrDetails_brakeEndurance = true;
-    (data as any).techRecord_adrDetails_weight = "123";
+    (data as any).techRecord_adrDetails_weight = 123;
     const res = isValidObject(schemaName, data);
     expect(res).toEqual(true);
   });

diff --git a/types/v3/tech-record/get/hgv/complete/index.d.ts b/types/v3/tech-record/get/hgv/complete/index.d.ts
@@ -105,7 +105,7 @@ export interface TechRecordGETHGVComplete {
   techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null;
   techRecord_adrDetails_brakeDeclarationIssuer?: string | null;
   techRecord_adrDetails_brakeEndurance?: boolean | null;
-  techRecord_adrDetails_weight?: string | null;
+  techRecord_adrDetails_weight?: number | null;
   techRecord_adrDetails_declarationsSeen?: boolean | null;
   techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null;
   techRecord_adrDetails_additionalNotes_number?: string[] | null;

diff --git a/types/v3/tech-record/get/hgv/skeleton/index.d.ts b/types/v3/tech-record/get/hgv/skeleton/index.d.ts
@@ -105,7 +105,7 @@ export interface TechRecordGETHGVSkeleton {
   techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null;
   techRecord_adrDetails_brakeDeclarationIssuer?: string | null;
   techRecord_adrDetails_brakeEndurance?: boolean | null;
-  techRecord_adrDetails_weight?: string | null;
+  techRecord_adrDetails_weight?: number | null;
   techRecord_adrDetails_declarationsSeen?: boolean | null;
   techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null;
   techRecord_adrDetails_additionalNotes_number?: string[] | null;

diff --git a/types/v3/tech-record/get/hgv/testable/index.d.ts b/types/v3/tech-record/get/hgv/testable/index.d.ts
@@ -105,7 +105,7 @@ export interface TechRecordGETHGVTestable {
   techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null;
   techRecord_adrDetails_brakeDeclarationIssuer?: string | null;
   techRecord_adrDetails_brakeEndurance?: boolean | null;
-  techRecord_adrDetails_weight?: string | null;
+  techRecord_adrDetails_weight?: number | null;
   techRecord_adrDetails_declarationsSeen?: boolean | null;
   techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null;
   techRecord_adrDetails_additionalNotes_number?: string[] | null;

diff --git a/types/v3/tech-record/get/lgv/complete/index.d.ts b/types/v3/tech-record/get/lgv/complete/index.d.ts
@@ -36,7 +36,7 @@ export interface TechRecordGETLGVComplete {
   techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null;
   techRecord_adrDetails_brakeDeclarationIssuer?: string | null;
   techRecord_adrDetails_brakeEndurance?: boolean | null;
-  techRecord_adrDetails_weight?: string | null;
+  techRecord_adrDetails_weight?: number | null;
   techRecord_adrDetails_declarationsSeen?: boolean | null;
   techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null;
   techRecord_adrDetails_additionalNotes_number?: string[] | null;

diff --git a/types/v3/tech-record/get/lgv/skeleton/index.d.ts b/types/v3/tech-record/get/lgv/skeleton/index.d.ts
@@ -36,7 +36,7 @@ export interface TechRecordGETLGVSkeleton {
   techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null;
   techRecord_adrDetails_brakeDeclarationIssuer?: string | null;
   techRecord_adrDetails_brakeEndurance?: boolean | null;
-  techRecord_adrDetails_weight?: string | null;
+  techRecord_adrDetails_weight?: number | null;
   techRecord_adrDetails_declarationsSeen?: boolean | null;
   techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null;
   techRecord_adrDetails_additionalNotes_number?: string[] | null;

diff --git a/types/v3/tech-record/get/trl/complete/index.d.ts b/types/v3/tech-record/get/trl/complete/index.d.ts
@@ -122,7 +122,7 @@ export interface TechRecordGETTRLComplete {
   techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null;
   techRecord_adrDetails_brakeDeclarationIssuer?: string | null;
   techRecord_adrDetails_brakeEndurance?: boolean | null;
-  techRecord_adrDetails_weight?: string | null;
+  techRecord_adrDetails_weight?: number | null;
   techRecord_adrDetails_declarationsSeen?: boolean | null;
   techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null;
   techRecord_adrDetails_additionalNotes_number?: string[] | null;

diff --git a/types/v3/tech-record/get/trl/skeleton/index.d.ts b/types/v3/tech-record/get/trl/skeleton/index.d.ts
@@ -122,7 +122,7 @@ export interface TechRecordGETTRLSkeleton {
   techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null;
   techRecord_adrDetails_brakeDeclarationIssuer?: string | null;
   techRecord_adrDetails_brakeEndurance?: boolean | null;
-  techRecord_adrDetails_weight?: string | null;
+  techRecord_adrDetails_weight?: number | null;
   techRecord_adrDetails_declarationsSeen?: boolean | null;
   techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null;
   techRecord_adrDetails_additionalNotes_number?: string[] | null;

diff --git a/types/v3/tech-record/get/trl/testable/index.d.ts b/types/v3/tech-record/get/trl/testable/index.d.ts
@@ -122,7 +122,7 @@ export interface TechRecordGETTRLTestable {
   techRecord_adrDetails_brakeDeclarationsSeen?: boolean | null;
   techRecord_adrDetails_brakeDeclarationIssuer?: string | null;
   techRecord_adrDetails_brakeEndurance?: boolean | null;
-  techRecord_adrDetails_weight?: string | null;
+  techRecord_adrDetails_weight?: number | null;
   techRecord_adrDetails_declarationsSeen?: boolean | null;
   techRecord_adrDetails_additionalNotes_guidanceNotes?: string[] | null;
   techRecord_adrDetails_additionalNotes_number?: string[] | null;