Lowercase emails and default form field values #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all emails to save in lowercase. I was looking through the database and saw someone signed up twice for some reason, and they used one email was all lowercase and the other had a capital letter. These are the same emails, so we should just store them as the same.
Also, I added defaults for form fields, so for example if someone decides to sign up by sending a POST request to the server via some other means than the website, ex
curl, and forget a field then it shouldn't error. I tried this and I got an error,MongoDB: CastError: Cast to number failed for value "undefined" at path "studentId"when only sending firstName. Seems like there should be a better way to do this (using the|| ''), so if anyone knows, I'm all ears.This would also fix trying to sign
undefinedup to our GitHub org.