Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Stop bundling pinocchio, hppfcl, eigenpy in wheels. #638

Open
duburcqa opened this issue Aug 25, 2023 · 1 comment
Open

[python] Stop bundling pinocchio, hppfcl, eigenpy in wheels. #638

duburcqa opened this issue Aug 25, 2023 · 1 comment
Labels
enhancement New feature or request P2 Low priority issue python

Comments

@duburcqa
Copy link
Owner

Beware all deps must be pinned to a specific version. Note that boost version requirement is incompatible between the binaries provided by apt robotpkg repository and the one deployed by pip.

cmeel-boost==1.81.0
cmeel-assimp==5.2.5
cmeel-octomap==1.9.8.1
cmeel-urdfdom==3.1.0.2
cmeel-tinyxml==2.6.2.1
eigenpy==2.9.2
pin==2.6.14
hpp-fcl==2.2.0
@duburcqa duburcqa added enhancement New feature or request python labels Aug 25, 2023
@duburcqa
Copy link
Owner Author

duburcqa commented Aug 25, 2023

Just add an extra requirement cmeel that install all these libs with the expected versions, so that the user has to opt-in a to get them. This way, building everything from source is not compromised and pre-compiled binaries can still be bundled with the wheel. A check at import of jiminy should be added to check the version number of libs pre-installed on the system and raise an exception if it does not match (suggesting to install jiminy_py[cmeel]). Note that support of robotpkg wheels will be compromise as it requires an older version of boost that is incompatible.

@duburcqa duburcqa added the P0 Highest priority issue label Aug 25, 2023
@duburcqa duburcqa added P1 Mid priority issue and removed P0 Highest priority issue labels Dec 9, 2023
@duburcqa duburcqa added P2 Low priority issue and removed P1 Mid priority issue labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Low priority issue python
Projects
None yet
Development

No branches or pull requests

1 participant