Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/viewer] Split the notions of view and Viewer. #513

Open
duburcqa opened this issue May 1, 2022 · 1 comment
Open

[python/viewer] Split the notions of view and Viewer. #513

duburcqa opened this issue May 1, 2022 · 1 comment
Labels
enhancement New feature or request P2 Low priority issue python

Comments

@duburcqa
Copy link
Owner

duburcqa commented May 1, 2022

  • panda3d-sync and meshcat backends should run simultaneously to avoid having to rely on dirty hack based on pyppeteer. It makes sense since panda3d-sync is always available and is computationally very cheap since the image is only rendered when needed. meshcat is still relevant for remote display and embedded views in notebooks.

  • View(s) and Viewer should be separated more clearly. A view is associated with a unique robot, while the viewer is shared between them. The parent Viewer must be provided to the view. The view can only delete its own state and not the whole Viewer at it is currently the case. Both must be managed separately. It is not an issue since current simulator is already hiding the management of the viewer to the user. And for power user it is quite easy to get the distinction and handle them manually.

  • It must be decided if it is still relevant to enforce having a single Viewer (backend) running at the same time. It is useful for meshcat that connects to any running server since it is supposed to be unique. This way, a persistent server can be started from outside and viewers from different sessions just connect to it simultaneously. The usefulness of this feature is questionable as it seems to have no real use case.

@duburcqa duburcqa added enhancement New feature or request python P2 Low priority issue P1 Mid priority issue and removed P2 Low priority issue P1 Mid priority issue labels May 1, 2022
@duburcqa duburcqa changed the title [python/viewer] Refactoring. [python/viewer] Split the notions of view and Viewer. Jul 11, 2022
@duburcqa duburcqa added P1 Mid priority issue and removed P2 Low priority issue labels Feb 11, 2023
@duburcqa duburcqa added P2 Low priority issue and removed P1 Mid priority issue labels Aug 10, 2023
@duburcqa
Copy link
Owner Author

After thinking, I'm in favour of moving the management of robots inside viewers at Simulator level. Viewer would be responsible for managing an instance of the backend, which would not have to be a singleton anymore (but would be by default). It does not really make sense for the viewer to manager this content the way it is currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Low priority issue python
Projects
Status: To do
Development

No branches or pull requests

1 participant