Merge pull request #17 from dsanchezcr/fix-npm

Fix npm

.github/workflows/workflow.yaml

@@ -106,7 +106,11 @@ jobs:
         npm publish --access public || echo "Version already exists on npmjs.com"
       env:
         NODE_AUTH_TOKEN: ${{ secrets.NPM_API_KEY }}
-
+    - name: Set up Node.js for GitHub Packages
+      uses: actions/setup-node@v4
+      with:
+        node-version: 'latest'
+        registry-url: 'https://npm.pkg.github.com'
     - name: Publish to GitHub Packages
       working-directory: ${{ env.npm-path }}
       run: |

README.md

@@ -43,7 +43,7 @@ The GetDollarExchangeRate and GetEuroExchangeRate methods return a tuple with th
 
 To install ColonesExchangeRate using npm, run the following command in the Package Manager Console:
 ```cli
-npm install @dsanchezcr/colones-exchange-rate
+npm i @dsanchezcr/colonesexchangerate
 ```
 
 ### Usage

src/npm/colonesexchangerate.js

@@ -1,4 +1,4 @@
-const axios = require('axios');
+import axios from 'axios';
 
 class colonesexchangerate {
   constructor() {
@@ -68,30 +68,31 @@ class colonesexchangerate {
     }
   }
 
-  async getDollarExchangeRate(includeDate = false) {
+  async getDollarExchangeRate() {
     try {
       const rate = await this.getExchangeRate();
       return {
-        date: includeDate ? rate?.dolar?.venta?.fecha : null,
+        date: rate?.dolar?.venta?.fecha || '',
         sale: rate?.dolar?.venta?.valor || 0,
         purchase: rate?.dolar?.compra?.valor || 0
       };
     } catch (ex) {
-      throw new Error(`Error trying to get the dollar exchange rate. Details: ${ex}`);
+      throw new Error(`Error getting dollar exchange rate. Details: ${ex}`);
     }
   }
 
-  async getEuroExchangeRate(includeDate = false) {
+  async getEuroExchangeRate() {
     try {
       const rate = await this.getExchangeRate();
       return {
-        date: includeDate ? rate?.euro?.fecha : null,
-        dollars: rate?.euro?.valor || 0
+        date: rate?.euro?.fecha || '',
+        dollars: rate?.euro?.dolares || 0,
+        colones: rate?.euro?.colones || 0
       };
     } catch (ex) {
-      throw new Error(`Error trying to get the euro exchange rate. Details: ${ex}`);
+      throw new Error(`Error getting euro exchange rate. Details: ${ex}`);
     }
   }
 }
 
-module.exports = colonesexchangerate;
+export default colonesexchangerate;

src/npm/colonesexchangerate.test.js

@@ -1,56 +1,52 @@
-const colonesexchangerate = require('./colonesexchangerate');
+import assert from 'assert';
+import colonesexchangerate from './colonesexchangerate.js';
 
-describe('colonesexchangerate', () => {
-  let converter;
+let converter = new colonesexchangerate();
 
-  beforeEach(() => {
-    converter = new colonesexchangerate();
-  });
-
-  test('converts dollars to colones', async () => {
-    const amount = 100;
-    const result = await converter.dollarsToColones(amount);
-    expect(Number(result)).toBeGreaterThan(0);
-  });
-
-  test('converts colones to dollars', async () => {
-    const amount = 1000;
-    const result = await converter.colonesToDollars(amount);
-    expect(Number(result)).toBeGreaterThan(0);
-  });
-
-  test('converts dollars to euros', async () => {
-    const amount = 100;
-    const result = await converter.dollarsToEuros(amount);
-    expect(Number(result)).toBeGreaterThan(0);
-  });
-
-  test('converts euros to dollars', async () => {
-    const amount = 100;
-    const result = await converter.eurosToDollars(amount);
-    expect(Number(result)).toBeGreaterThan(0);
-  });
-
-  test('converts colones to euros', async () => {
-    const amount = 1000;
-    const result = await converter.colonesToEuros(amount);
-    expect(Number(result)).toBeGreaterThan(0);
-  });
-
-  test('converts euros to colones', async () => {
+async function runTests() {
+  try {
     const amount = 100;
-    const result = await converter.eurosToColones(amount);
-    expect(Number(result)).toBeGreaterThan(0);
-  });
-
-  test('gets dollar exchange rate', async () => {
-    const rate = await converter.getDollarExchangeRate();
-    expect(rate).toHaveProperty('sale');
-    expect(rate).toHaveProperty('purchase');
-  });
-
-  test('gets euro exchange rate', async () => {
-    const rate = await converter.getEuroExchangeRate();
-    expect(rate).toHaveProperty('dollars');
-  });
-});
+    let result = await converter.dollarsToColones(amount);
+    console.log(`Dollars to colones: ${result}`);
+    assert(Number(result) > 0, 'Dollars to colones conversion result should be greater than 0');
+
+    result = await converter.colonesToDollars(amount);
+    console.log(`Colones to dollars: ${result}`);
+    assert(Number(result) > 0, 'Colones to dollars conversion result should be greater than 0');
+
+    result = await converter.dollarsToEuros(amount);
+    console.log(`Dollars to euros: ${result}`);
+    assert(Number(result) > 0, 'Dollars to euros conversion result should be greater than 0');
+
+    result = await converter.eurosToDollars(amount);
+    console.log(`Euros to dollars: ${result}`);
+    assert(Number(result) > 0, 'Euros to dollars conversion result should be greater than 0');
+
+    result = await converter.colonesToEuros(amount);
+    console.log(`Colones to euros: ${result}`);
+    assert(Number(result) > 0, 'Colones to euros conversion result should be greater than 0');
+
+    result = await converter.eurosToColones(amount);
+    console.log(`Euros to colones: ${result}`);
+    assert(Number(result) > 0, 'Euros to colones conversion result should be greater than 0');
+
+    let rate = await converter.getDollarExchangeRate();
+    console.log(`Dollar exchange rate: ${JSON.stringify(rate)}`);
+    assert(rate.hasOwnProperty('date'), 'Dollar exchange rate should have a date property');
+    assert(rate.hasOwnProperty('sale'), 'Dollar exchange rate should have a sale property');
+    assert(rate.hasOwnProperty('purchase'), 'Dollar exchange rate should have a purchase property');
+
+    rate = await converter.getEuroExchangeRate();
+    console.log(`Euro exchange rate: ${JSON.stringify(rate)}`);
+    assert(rate.hasOwnProperty('date'), 'Euro exchange rate should have a date property');
+    assert(rate.hasOwnProperty('dollars'), 'Euro exchange rate should have a dollars property');
+    assert(rate.hasOwnProperty('colones'), 'Euro exchange rate should have a colones property');
+
+    console.log('All tests passed!');
+  } catch (error) {
+    console.error(error);
+    process.exit(1);
+  }
+}
+
+runTests();