allow notifications to be added as another event #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, composing triggers like below will be possible
trigger := htmx.NewTrigger()
trigger.AddEvent("fl:record:updated")
trigger.AddSuccess("Transcription updated")
hx.TriggerWithObject(trigger)
|
Hi! Thanks for the contribution! I will give it a look tomorrow and get back to you. I assume this doesn't break current flows? |
|
Hi! Thanks for such a quick notice. It should not break anything. Standard notification handlers like TriggerInfo, TriggerCustom, TriggerError,.. still work. |
donseba
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I hit a usecase where I wanted to send in one response a Success notification to a user and also second event so that HTMX can fetch new data.
I moved logic composing notify object from the handler
notifyObjectinto a new methodaddNotifyObjectin Trigger struct. This struct also now exposes public methods like AddSuccess, AddInfo, AddError etc..So that composing triggers like below will be possible:
Also I added tests for a good measure. :-)