hotfix: Disable camlimages (#48)

* hotfix: Temporarily disable camlimages * hotfix: disable camlimages * hotfix: Temprorary disable support of jpeg and xpm * Remove camlimages completely * Update README
dmtrKovalenko · Jun 28, 2021 · ef6bb98 · ef6bb98
1 parent f73034c
commit ef6bb98
Show file tree

Hide file tree

Showing 11 changed files with 43 additions and 355 deletions.
diff --git a/README.md b/README.md
@@ -25,17 +25,17 @@ ODiff is a blazing fast native image comparison tool. Check [benchmarks](#benchm
 
 ## Features
 
-- ✅ .png, .jpg, .jpeg, .bmp, .tiff, .xpm – Files supported.
 - ✅ Cross-format comparison - Yes .jpg vs .png comparison without any problems.
 - ✅ Supports comparison of images with different layouts.
 - ✅ Anti-aliasing detection
 - ✅ Ignoring regions
 - ✅ Using [YIQ NTSC
   transmission algorithm](http://www.progmat.uaem.mx:8080/artVol2Num2/Articulo3Vol2Num2.pdf) to determine visual difference.
-- ✅ No dependencies for `.png` comparison. Only several system C dependencies for other formats, [more info](#lib-dependencies).
+- ✅ No dependencies for `.png` comparison
 
 ### Coming in the nearest future:
 
+- ⏹ Support different image formats `.jpeg`, `.tiff` and `.bmp` 
 - ⏹ Reading image from memory buffer
 - ⏹ Reading images from url 
 
@@ -144,12 +144,6 @@ Then give it a try 👀
 ```
 odiff --help
 ```
-
-### lib* dependencies
-
-Make sure if you want to compare **other** than `.png` images it is required to install the proper C library for each format. For `.jpg` – [libjpg](http://libjpeg.sourceforge.net/), for `.tiff` –[libtiff](http://www.libtiff.org/), for `.xpm` - libxpm. 
-
-`.png` images works out of the box.
 
 ### MacOS
 

diff --git a/bin/Main.re b/bin/Main.re
@@ -9,7 +9,8 @@ let getIOModule = (filename, ~antialiasing) =>
         (module ODiffIO.PureC_IO_Bigarray.IO): (module ImageIO)
       )
     | ".png" => ((module ODiffIO.PureC_IO.IO): (module ImageIO))
-    | _ => ((module ODiffIO.CamlImagesIO.IO): (module ImageIO))
+    | unsupportedFormat =>
+      failwith("This format is not supported: " ++ unsupportedFormat)
   );
 
 type diffResult('output) = {

diff --git a/bin/ODiffBin.re b/bin/ODiffBin.re
@@ -132,7 +132,7 @@ let cmd = {
     ),
     Term.info(
       "odiff",
-      ~version="2.4.0",
+      ~version="2.4.1",
       ~doc="Find difference between 2 images.",
       ~exits=[
         Term.exit_info(0, ~doc="on image match"),

diff --git a/esy.lock/index.json b/esy.lock/index.json
diff --git a/esy.lock/opam/base.v0.14.1/opam b/esy.lock/opam/base.v0.14.1/opam
diff --git a/esy.lock/opam/camlimages.5.0.4/opam b/esy.lock/opam/camlimages.5.0.4/opam