Add ClimateEntityFeature.TURN_OFF for Google Assistant calls #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google Assistant expects to call the turn_off service which does not exist unless specifically enabled as a ClimateEntityFeature.TURN_OFF feature. Previously calls to turn off my Kumo devices would fail silently from Google and an error message in Home Assistant regarding an unsupported service. I have tested this change to fix my issue.
|
Discussion in #137 |
|
@dlarrick any thoughts on this one? Seems to work great for my setup. (Both via Google Assistant and Home Assistant apps) |
|
Didn't we remove this to stop some deprecation warning? Let me dig up that PR too... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Assistant expects to call the turn_off service which does not exist unless specifically enabled as a ClimateEntityFeature.TURN_OFF feature.
Previously calls to turn off my Kumo devices would fail silently from Google and an error message in Home Assistant regarding an unsupported service.
I have tested this change to fix my issue.