Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

319 Windows Hang on Exit #320

Merged
merged 6 commits into from
Mar 14, 2024
Merged

319 Windows Hang on Exit #320

merged 6 commits into from
Mar 14, 2024

Conversation

trisyoungs
Copy link
Member

Attempts to fix #319 where waitress-serve stoically refuses to terminate (i.e. it seems to ignore QProcess::terminate().

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Test Results

82 tests  ±0   82 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e0273da. ± Comparison against base commit e280755.

This pull request removes 82 and adds 82 tests. Note that renamed tests count towards both.
tests.test_journal ‑ test_basic_generation
tests.test_journal ‑ test_run_data_contains_run_number[1]
tests.test_journal ‑ test_run_data_contains_run_number[2]
tests.test_journal ‑ test_run_data_contains_run_number[3]
tests.test_journal ‑ test_run_data_contains_run_number[6]
tests.test_journal ‑ test_run_data_contains_run_number[8]
tests.test_journal ‑ test_run_data_contains_run_number[9]
tests.test_journal ‑ test_run_data_does_not_contain_run_number[0]
tests.test_journal ‑ test_run_data_does_not_contain_run_number[12301]
tests.test_journal ‑ test_run_data_does_not_contain_run_number[4]
…
src.jv2backend.tests.test_journal ‑ test_basic_generation
src.jv2backend.tests.test_journal ‑ test_run_data_contains_run_number[1]
src.jv2backend.tests.test_journal ‑ test_run_data_contains_run_number[2]
src.jv2backend.tests.test_journal ‑ test_run_data_contains_run_number[3]
src.jv2backend.tests.test_journal ‑ test_run_data_contains_run_number[6]
src.jv2backend.tests.test_journal ‑ test_run_data_contains_run_number[8]
src.jv2backend.tests.test_journal ‑ test_run_data_contains_run_number[9]
src.jv2backend.tests.test_journal ‑ test_run_data_does_not_contain_run_number[0]
src.jv2backend.tests.test_journal ‑ test_run_data_does_not_contain_run_number[12301]
src.jv2backend.tests.test_journal ‑ test_run_data_does_not_contain_run_number[4]
…

♻️ This comment has been updated with latest results.

@trisyoungs trisyoungs merged commit 202bf0e into develop Mar 14, 2024
7 checks passed
@trisyoungs trisyoungs deleted the 319-windows-hang-on-exit branch March 14, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hang on exit
1 participant