fix(carousel): Role=group not valid inside a list #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @larowlan for your contribution! I appreciate the effort you've put into ensuring our components adhere to accessibility standards. Removing the role="group" attribute from the carousel component makes sense given that it's not valid inside a list structure. This change will help improve the accessibility of our component as per the axe/playwright tests. We'll verify that this removal doesn't affect any other functionality or introduce new accessibility issues and then merge this PR early next week if there are no issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using the design system in a storybook setup.
With this setup we're using storybook's test runner to test a11y of our components using axe/playwright.
It is failing for the carousel component with an invalid list structure/role attribute.
role="group"is not valid inside a list.