Merging in new Cryptography module

dvwa/css/main.css

@@ -86,6 +86,22 @@ ul + ul, ul + ul.menuBlocks, ul + h1, ul + h2, ul + p {
 	font-size: 13px;
 }
 
+div.nearly {
+	border: 2px solid #0000ff;
+	padding: 10px 20px 10px 20px;
+	margin-top: 15px;
+	margin-bottom: 15px;
+}
+
+div.success {
+	border: 2px solid #00ff00;
+	padding: 10px 20px 10px 20px;
+	text-align: center;
+	font-weight: bold;
+	margin-top: 15px;
+	margin-bottom: 15px;
+}
+
 div.warning {
 	border: 2px solid #ff0000;
 	padding: 10px 20px 10px 20px;

dvwa/includes/dvwaPage.inc.php

@@ -305,6 +305,7 @@ function dvwaHtmlEcho( $pPage ) {
 			$menuBlocks[ 'vulnerabilities' ][] = array( 'id' => 'authbypass', 'name' => 'Authorisation Bypass', 'url' => 'vulnerabilities/authbypass/' );
 		}
 		$menuBlocks[ 'vulnerabilities' ][] = array( 'id' => 'open_redirect', 'name' => 'Open HTTP Redirect', 'url' => 'vulnerabilities/open_redirect/' );
+		$menuBlocks[ 'vulnerabilities' ][] = array( 'id' => 'encryption', 'name' => 'Cryptography', 'url' => 'vulnerabilities/cryptography/' );
 	}
 
 	$menuBlocks[ 'meta' ] = array();
@@ -512,7 +513,7 @@ function dvwaSourceHtmlEcho( $pPage ) {
 
 // To be used on all external links --
 function dvwaExternalLinkUrlGet( $pLink,$text=null ) {
-	if(is_null( $text )) {
+	if(is_null( $text ) || $text == "") {
 		return '<a href="' . $pLink . '" target="_blank">' . $pLink . '</a>';
 	}
 	else {

vulnerabilities/cryptography/help/help.php

@@ -0,0 +1,193 @@
+<script>
+function show_answer(which) {
+	var x = document.getElementById(which + "_answer");
+	if (x.style.display === "" || x.style.display === "none") {
+		x.style.display = "block";
+	} else {
+		x.style.display = "none";
+	}
+}
+</script>
+<style>
+	pre {
+		overflow-x: auto;
+		white-space: pre-wrap;
+		word-wrap: break-word;
+	}
+	#low_answer,#medium_answer,#high_answer {
+		display: none;
+	}
+</style>
+
+<div class="body_padded">
+	<h1>Help - Cryptographic Problems</h1>
+
+	<div id="code">
+	<table width='100%' bgcolor='white' style="border:2px #C0C0C0 solid">
+	<tr>
+	<td><div id="code">
+		<h3>About</h3>
+		<p>
+		Cryptography is key area of security and is used to keep secrets secret. When implemented badly these secrets can be leaked or the crypto manipulated to bypass protections.
+		</p>
+		<p>
+		This module will look at three weaknesses, using encoding instead of encryption, using algorithms with known weaknesses, and padding oracle attacks.
+		</p>
+
+		<br /><hr /><br />
+
+		<h3>Objective</h3>
+		<p>Each level has its own objective but the general idea is to exploit weak cryptographic implementations.</p>
+
+		<br /><hr /><br />
+
+		<h3>Low Level</h3>
+		<p>The thing to notice is the mention of encoding rather than encryption, that should give you a hint about the vulnerability here.</p>
+		<p>
+		<button onclick="show_answer('low')">Show Answer</button>
+		</p>
+		<div id="low_answer">
+		<p>Start by encoding a few messages and looking at the output, if you have spent any time around encoding standards you should be able to tell that it is in Base64. Could it be that simple? Try Base64 decoding some test strings to find out:</p>
+		<pre><code>encode (hello) -> HwQPBBs=
+base64decode (HwQPBBs=) -> 0x1f 0x04 0x0f 0x04 0x1b</code></pre>
+		<pre><code>encode (a secret) -> FkEQDRcFChs=
+base64decode (FkEQDRcFChs=) -> 0x16 0x41 0x10 0x0d 0x17 0x05 0x0a 0x1b</code></pre>
+<p>
+That failed, but what you might notice is that the number of output characters matches the number of input characters. Another common encoding method that is sometimes mistaken for encryption is XOR, this takes the clear text input and XORs each character with a key which is repeated or truncated to be the same length as the input.</p>
+<p>
+XOR is associative, this means that if you XOR the clear text with the key you get the cipher text and if you XOR the cipher text with the key you get the clear text, what it also means is if you XOR the clear text with the cipher text, you get the key. Let's try this with our examples:
+</p>
+		<pre><code>encode (hello) -> HwQPBBs=
+xor (HwQPBBs=, hello) -> wacht</code></pre>
+<p>
+This looks promising, let's try the second example:
+</p>
+		<pre><code>encode (a secret) -> FkEQDRcFChs=
+xor (FkEQDRcFChs=, a secret) -> wachtwoo</code></pre>
+
+<p>
+There is no repetition in the key yet so let's try with a longer string.
+</p>
+
+		<pre><code>encode (thisisaverylongstringtofindthepassword) -> AwkKGx0EDhkXFg4NDAYTBBsdGwoQFQwOHRkLGxoBBwAQGwMYHQs=
+xor (thisisaverylongstringtofindthepassword, base64decode (AwkKGx0EDhkXFg4NDAYTBBsdGwoQFQwOHRkLGxoBBwAQGwMYHQs=)) -> wachtwoordwachtwoordwachtwoordwachtwoo</code></pre>
+
+<p>
+It looks like we have found our key "wachtwoord". Let's give it a try on our challenge string:
+</p>
+
+<pre><code>xor (base64decode(Lg4WGlQZChhSFBYSEB8bBQtPGxdNQSwEHREOAQY=), wachtwoord) -> Your new password is: Olifant</code></pre>
+
+
+<p>
+And there we have it, the message we are looking for and the password we need to login.
+</p>
+
+		<p>Another lesson here, do not assume that the messages or the underlying system you are working with is in English. The key "wachtwoord" is Dutch for password.</p>
+		</div>
+
+		<h3>Medium Level</h3>
+		<p>The tokens are encrypted using an Electronic Code Book based algorithm (aes-128-ecb). In this mode, the clear text is broken down into fixed sized blocks and each block is encrypted independently of the rest. This results in a cipher text that is made up from a number of individual blocks with no way to tie them together. Worse than this, any two blocks, from any two clear text inputs, are interchangeable as long as they have been encrypted with the same key. In our example, this means you can take blocks from the three different tokens to make your own token. </p>
+		<p>
+		<button onclick="show_answer('medium')">Show Answer</button>
+		</p>
+		<div id="medium_answer">
+		<p>
+			How do you know the block size? This is given in the algorithm name. aes-128-ebc is a 128 bit block cipher. 128 bits is 16 bytes, but to make things human readable, the bytes are represented as hex characters meaning each byte is two characters. This gives you a block size of 32 characters. Sooty's token is 192 characters long, 192 / 32 = 6 and so Sooty's token has six code blocks.
+		</p>
+
+		<p>
+Let's start by breaking the tokens down into blocks.</p>
+<p><strong>Sooty:</strong></p>
+<pre><code>e287af752ed3f9601befd45726785bd9
+b85bb230876912bf3c66e50758b222d0
+837d1e6b16bfae07b776feb7afe57630
+5aec34b41499579d3fb6acc8dc92fd5f
+cea8743c3b2904de83944d6b19733cdb
+48dd16048ed89967c250ab7f00629dba</code></pre>
+</p>
+
+<p><strong>Sweep:</strong></p>
+<pre><code>3061837c4f9debaf19d4539bfa0074c1
+b85bb230876912bf3c66e50758b222d0
+83f2d277d9e5fb9a951e74bee57c77a3
+caeb574f10f349ed839fbfd223903368
+873580b2e3e494ace1e9e8035f0e7e07</code></pre>
+
+<p><strong>Soo:</strong></p>
+<pre><code>5fec0b1c993f46c8bad8a5c8d9bb9698
+174d4b2659239bbc50646e14a70becef
+83f2d277d9e5fb9a951e74bee57c77a3
+c9acb1f268c06c5e760a9d728e081fab
+65e83b9f97e65cb7c7c4b8427bd44abc
+16daa00fd8cd0105c97449185be77ef5</code></pre>
+
+		<p>
+		Each token has broken down nicely into blocks so we are on the right track.
+		</p>
+		<p>
+		If you look carefully at the blocks you will see that there are some that repeat over the different tokens, this means that the same clear text has been encrypted to create the block. If we look at the description we can try to map these to the JSON object.
+		</p>
+		<p>
+		Taking Sooty as an example:
+		</p>
+<p><strong>Sooty:</strong></p>
+<pre><code>e287af752ed3f9601befd45726785bd9 <- Username
+b85bb230876912bf3c66e50758b222d0 <- Expiry
+837d1e6b16bfae07b776feb7afe57630 <- Level
+5aec34b41499579d3fb6acc8dc92fd5f <- Bio
+cea8743c3b2904de83944d6b19733cdb
+48dd16048ed89967c250ab7f00629dba</code></pre>
+</p>
+		<p>
+		Assuming we are right with our mappings, if you compare the blocks that match you can see that Sooty and Sweep both have the same expiry block (b85bb230876912bf3c66e50758b222d0) and both Sweep and Soo have the same level block (83f2d277d9e5fb9a951e74bee57c77a3). This matches with what we know about the tokens as both Sooty and Sweep have expired tokens and both Sweep and Soo are users, not admins.
+		</p>
+		<p>
+		Knowing all this, we can now create our forged session token. We need to take the username block from Sweep, the expiry block from Soo and the level block from Sooty. We can then finish the token off with the remaining blocks from any of the tokens. This gives us:
+		</p>
+<pre><code>3061837c4f9debaf19d4539bfa0074c1 <- Sweep as username
+174d4b2659239bbc50646e14a70becef <- Soo's expiry time
+837d1e6b16bfae07b776feb7afe57630 <- Sooty's admin privileges
+caeb574f10f349ed839fbfd223903368 <- Finish off with Sweep's bio
+873580b2e3e494ace1e9e8035f0e7e07</code></pre>
+		<p>
+			Which gives us...
+		</p>
+		<p>
+<textarea style="width:746px; height: 35px">3061837c4f9debaf19d4539bfa0074c1174d4b2659239bbc50646e14a70becef837d1e6b16bfae07b776feb7afe57630caeb574f10f349ed839fbfd223903368873580b2e3e494ace1e9e8035f0e7e07</textarea>
+		</p>
+		<p>
+		This is a very contrived setup with the tokens tweaked to force blocks to map to the JSON object so manipulation is easier to do, in the real world it is unlikely to be this easy however as data is often formed from fixed sized blocks overlaps can happen in a way that mixing blocks up results in valid data. Sometimes just being able to pass invalid data is enough so all that is needed is to swap blocks in a way that they can be decrypted and then passed on to the rest of the system where they will cause errors.
+		</p>
+		<p>
+		If you want to play with this some more, there is a script called <a href="cryptography/source/download_ecb_attack.php" download>ecb_attack.php</a> in the sources directory which shows how the tokens were generated and lets you combine them in different ways to create custom tokens.
+		</p>
+		</div>
+
+		<h3>High Level</h3>
+		<p>The system is using AES-128-CBC which means it is vulnerable to a padding oracle attack.</p>
+
+		<p>
+		<button onclick="show_answer('high')">Show Answer</button>
+		</p>
+
+		<div id="high_answer">
+		<p>Rather than try to explain this here, go read this excelent write up on the attack by Eli Sohl.</p>
+		<p><a target="_blank" href="https://www.nccgroup.com/uk/research-blog/cryptopals-exploiting-cbc-padding-oracles/">Cryptopals: Exploiting CBC Padding Oracles</a></p>
+		<p>
+		If you want to play with this some more, there is a script called <a href="cryptography/source/download_oracle_attack.php" download>oracle_attack.php</a> in the sources directory which runs through the full attack with debug. You can run this either against the DVWA site or it will run locally against its own pretend web server.
+		</p>
+		</div>
+
+		<h3>Impossible Level</h3>
+		<p>You can never say impossible in crypto as something that would take years today could take minutes in the future when a new attack is found or when processing power takes a giant leam forward.</p>
+		<p>
+		The current recommended alternative to AES-CBC is AES-GCM and so the system uses that here. 256 bit blocks rather than 128 bit blocks are used, and a unique IV used for every message. This may be secure today but who knows what tomorrow brings?
+		</p>
+	</div></td>
+	</tr>
+	</table>
+
+	</div>
+
+</div>

vulnerabilities/cryptography/index.php

@@ -0,0 +1,64 @@
+<?php
+
+define( 'DVWA_WEB_PAGE_TO_ROOT', '../../' );
+require_once DVWA_WEB_PAGE_TO_ROOT . 'dvwa/includes/dvwaPage.inc.php';
+
+dvwaPageStartup( array( 'authenticated' ) );
+
+$page = dvwaPageNewGrab();
+$page[ 'title' ]   = 'Vulnerability: Cryptography Problems' . $page[ 'title_separator' ].$page[ 'title' ];
+$page[ 'page_id' ] = 'cryptography';
+$page[ 'help_button' ]   = 'cryptography';
+$page[ 'source_button' ] = 'cryptography';
+
+dvwaDatabaseConnect();
+
+$vulnerabilityFile = '';
+switch( dvwaSecurityLevelGet() ) {
+	case 'low':
+		$vulnerabilityFile = 'low.php';
+		break;
+	case 'medium':
+		$vulnerabilityFile = 'medium.php';
+		break;
+	case 'high':
+		$vulnerabilityFile = 'high.php';
+		break;
+	default:
+		$vulnerabilityFile = 'impossible.php';
+		break;
+}
+
+require_once DVWA_WEB_PAGE_TO_ROOT . "vulnerabilities/cryptography/source/{$vulnerabilityFile}";
+
+$page[ 'body' ] .= "<div class=\"body_padded\">
+	<h1>Vulnerability: Cryptography Problems</h1>
+
+	<div class=\"vulnerable_code_area\">
+";
+
+$page[ 'body' ] .= "
+		{$html}
+	</div>
+
+	<h2>More Information</h2>
+	<ul>
+		<li>" . dvwaExternalLinkUrlGet( 'https://exploit-notes.hdks.org/exploit/cryptography/algorithm/aes-ecb-padding-attack', "AES-ECB Padding Attack" ) . "</li>
+		<li>" . dvwaExternalLinkUrlGet( 'https://www.scottbrady91.com/cryptopals/implementing-and-breaking-aes-ecb', "Implementing and breaking AES ECB") . "</li>
+		<li>" . dvwaExternalLinkUrlGet( 'https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation', "Wikipedia - Block cipher mode of operation" ) . "</li>
+		<li>" . dvwaExternalLinkUrlGet( 'https://www.nccgroup.com/us/research-blog/cryptopals-exploiting-cbc-padding-oracles/', "Cryptopals: Exploiting CBC Padding Oracles - Best article") . "</li> 
+		<li>" . dvwaExternalLinkUrlGet( 'https://yurichev.org/pkcs7/', "[Crypto] PKCS#7 padding") . "</li> 
+		<li>" . dvwaExternalLinkUrlGet( 'https://en.wikipedia.org/wiki/Padding_oracle_attack', "Padding oracle attack") . "</li> 
+		<li>" . dvwaExternalLinkUrlGet( 'https://medium.com/@masjadaan/oracle-padding-attack-a61369993c86', "Oracle Padding Attack") . "</li> 
+		<li>" . dvwaExternalLinkUrlGet( 'https://robertheaton.com/2013/07/29/padding-oracle-attack/', "The Padding Oracle Attack") . "</li> 
+		<li>" . dvwaExternalLinkUrlGet( 'https://en.wikipedia.org/wiki/Padding_%28cryptography%29', "Wikipedia - Padding (cryptography)") . "</li> 
+		<li>" . dvwaExternalLinkUrlGet( 'https://gchq.github.io/CyberChef/', "CyberChef") . "</li> 
+		<li>" . dvwaExternalLinkUrlGet( 'https://www.101computing.net/xor-encryption-algorithm/', "XOR Encryption Algorithm") . "</li> 
+		<li>" . dvwaExternalLinkUrlGet( 'https://en.wikipedia.org/wiki/XOR_cipher', "XOR Cipher") . "</li> 
+	</ul>
+</div>\n";
+
+dvwaHtmlEcho( $page );
+
+?>
+

vulnerabilities/cryptography/source/check_token_high.php

@@ -0,0 +1,25 @@
+<?php
+
+require_once ("token_library_high.php");
+
+$ret = "";
+
+if ($_SERVER['REQUEST_METHOD'] == "POST") {
+	if ($_SERVER['CONTENT_TYPE'] != "application/json") {
+		$ret = json_encode (array (
+						"status" => 527,
+						"message" => "Content type must be application/json"
+					));
+	} else {
+		$token = $jsonData = file_get_contents('php://input');
+		$ret = check_token ($token);
+	}
+} else {
+	$ret = json_encode (array (
+					"status" => 405,
+					"message" => "Method not supported"
+				));
+}
+
+print $ret;
+exit;

vulnerabilities/cryptography/source/check_token_impossible.php

@@ -0,0 +1,25 @@
+<?php
+
+require_once ("token_library_impossible.php");
+
+$ret = "";
+
+if ($_SERVER['REQUEST_METHOD'] == "POST") {
+	if ($_SERVER['CONTENT_TYPE'] != "application/json") {
+		$ret = json_encode (array (
+						"status" => 527,
+						"message" => "Content type must be application/json"
+					));
+	} else {
+		$token = $jsonData = file_get_contents('php://input');
+		$ret = check_token ($token);
+	}
+} else {
+	$ret = json_encode (array (
+					"status" => 405,
+					"message" => "Method not supported"
+				));
+}
+
+print $ret;
+exit;

vulnerabilities/cryptography/source/download_ecb_attack.php

@@ -0,0 +1,16 @@
+<?php
+
+// open the file in a binary mode
+$name = './ecb_attack.php';
+$fp = fopen($name, 'rb');
+
+// send the right headers
+header("Content-Type: application/x-httpd-php");
+header("Content-Length: " . filesize($name));
+header("Content-Disposition: attachment; filename= ecb_attack.php");
+
+// dump the picture and stop the script
+fpassthru($fp);
+exit;
+
+?>

vulnerabilities/cryptography/source/download_oracle_attack.php

@@ -0,0 +1,16 @@
+<?php
+
+// open the file in a binary mode
+$name = './oracle_attack.php';
+$fp = fopen($name, 'rb');
+
+// send the right headers
+header("Content-Type: application/x-httpd-php");
+header("Content-Length: " . filesize($name));
+header("Content-Disposition: attachment; filename= oracle_attack.php");
+
+// dump the picture and stop the script
+fpassthru($fp);
+exit;
+
+?>