Add npj Comput Mater citation

[bobleesj]

Followed the citation format from diffpy.structure

Journal abbreviation from

https://doi.org/10.1038/s41524-024-01377-5

[sbillinge]

thanks @bobleesj we just need a news for this.

There is an issue on cookiecutter to add GH actions that check for news so PRs will fail CI if they don't have updated news items, Maybe it is a good time to implelment that. We were going to copy these from the xonsh project on xonsh/xonsh on GH but I think we never did. Let's also add those workflows to existing repos as we remember (i.e., here, now).

[bobleesj]

I agree that we need a general CI checking for news items. Will work on it.

[bobleesj]

Testing 1. Added news called citation.rst

• As expected, works.

[bobleesj]

Testing 2. Remove citation.rst

• Expect to fail

[bobleesj]

Warning! No news item is found for this PR. If this is an user facing change/feature/fix, please add a news item by copying the format from news/TEMPLATE.rst.

@sbillinge It appears that when no news .rst is found, the CI generates a comment as quoted above instead of failing the CI.

Fail or write comment?

The last part of the script: https://github.com/diffpy/diffpy.snmf/pull/79/files

pr.create_issue_comment(
            """\
**Warning!** No news item is found for this PR. If this is an user facing change/feature/fix,
 please add a news item by copying the format from `news/TEMPLATE.rst`.
"""

Please do not merge yet! Since CI is working as intended, I will make a new PR for bumping Python 3.9 to 3.12

[sbillinge]

@bobleesj lovely!

[bobleesj]

@sbillinge

Fail or write comment?

Please suggest:

When there is no news item, CI does not fail (by design). Instead, it writes a comment.

Would you want me to modify the script so that the CI fails?