BMC: support full LTL #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
BMC-full-LTL
branch
from
d29439c
to
201286d
Compare
kroening
force-pushed
the
BMC-full-LTL
branch
6 times, most recently
from
d9c02b5
to
fa9bdf4
Compare
Full LTL is supported by the word-level BMC engine.
kroening
force-pushed
the
BMC-full-LTL
branch
from
fa9bdf4
to
998bb30
Compare
tautschnig
approved these changes
Sep 24, 2024
Comment on lines
41
to
+43
| bool bmc_supports_LTL_property(const exprt &expr) | ||
| { | ||
| // We support | ||
| // * formulas that contain no temporal operator besides X | ||
| // * Gφ, where φ contains no temporal operator besides X | ||
| // * Fφ, where φ contains no temporal operator besides X | ||
| // * GFφ, where φ contains no temporal operator besides X | ||
| // * conjunctions of supported LTL properties | ||
| auto non_X_LTL_operator = [](const exprt &expr) | ||
| { return is_LTL_operator(expr) && expr.id() != ID_X; }; | ||
|
|
||
| if(!has_subexpr(expr, non_X_LTL_operator)) | ||
| { | ||
| return true; | ||
| } | ||
| else if(expr.id() == ID_F) | ||
| { | ||
| return !has_subexpr(to_F_expr(expr).op(), non_X_LTL_operator); | ||
| } | ||
| else if(expr.id() == ID_G) | ||
| { | ||
| auto &op = to_G_expr(expr).op(); | ||
| if(op.id() == ID_F) | ||
| { | ||
| return !has_subexpr(to_F_expr(op).op(), non_X_LTL_operator); | ||
| } | ||
| else | ||
| { | ||
| return !has_subexpr(op, non_X_LTL_operator); | ||
| } | ||
| } | ||
| else if(expr.id() == ID_and) | ||
| { | ||
| for(auto &op : expr.operands()) | ||
| if(!bmc_supports_LTL_property(op)) | ||
| return false; | ||
| return true; | ||
| } | ||
| else | ||
| return false; | ||
| return true; |
There was a problem hiding this comment.
Should this function just be removed?
There was a problem hiding this comment.
Look at the pretty symmetry of bmc_supports_property(...)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full LTL is supported by the word-level BMC engine.