Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMT2: implement range type #8466

Merged
merged 1 commit into from
Sep 23, 2024
Merged

SMT2: implement range type #8466

merged 1 commit into from
Sep 23, 2024

Conversation

kroening
Copy link
Member

This adds missing support for encoding the range_typet to the SMT2 backend.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This adds missing support for encoding the range_typet to the SMT2 backend.
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 34 lines in your changes missing coverage. Please review.

Project coverage is 78.22%. Comparing base (d2b4455) to head (e21c686).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/smt2/smt2_conv.cpp 5.55% 34 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8466      +/-   ##
===========================================
- Coverage    78.31%   78.22%   -0.10%     
===========================================
  Files         1726     1726              
  Lines       188817   189038     +221     
  Branches     18270    18265       -5     
===========================================
  Hits        147874   147874              
- Misses       40943    41164     +221     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review September 23, 2024 10:58
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something that is going to test this?

@kroening
Copy link
Member Author

Is there something that is going to test this?

Not easy -- the only language I know where this is of use are SMV and VHDL.

I think I want to make the architecture of the decision procedure and the simplifier we have more modular, enabling us to plug these in where they are needed.

@kroening kroening merged commit a209b44 into develop Sep 23, 2024
39 of 41 checks passed
@kroening kroening deleted the smt2-range branch September 23, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants