Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C library: Apple does not adhere to aarch64 ABI #8461

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

tautschnig
Copy link
Collaborator

The fix from #8366 must not be used on macOS as that platform still uses __builtin_va_list instead of the ARM-mandated struct.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.31%. Comparing base (5bd494a) to head (9c9b52e).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8461   +/-   ##
========================================
  Coverage    78.31%   78.31%           
========================================
  Files         1726     1726           
  Lines       188817   188817           
  Branches     18270    18270           
========================================
  Hits        147874   147874           
  Misses       40943    40943           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The fix from diffblue#8366 must not be used on macOS as that platform still uses
`__builtin_va_list` instead of the ARM-mandated struct.
@tautschnig tautschnig merged commit 0831d00 into diffblue:develop Sep 19, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the fix-aarch64-va_list branch September 19, 2024 16:26
tautschnig added a commit to tautschnig/cbmc that referenced this pull request Sep 19, 2024
This patch release addresses build failures on Apple Silicon (via PR diffblue#8461).
@tautschnig tautschnig mentioned this pull request Sep 19, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants