Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts: always remove spurious do {... } while(0) loops #8459

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

tautschnig
Copy link
Collaborator

None of our contracts instrumentation should spuriously get confused by these pseudo-loops (suggesting to users that they need to unwind those loops). We already used to do this for non-DFCC code, now also apply it with dynamic frames.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

None of our contracts instrumentation should spuriously get confused by
these pseudo-loops (suggesting to users that they need to unwind those
loops). We already used to do this for non-DFCC code, now also apply it
with dynamic frames.
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (5002f3b) to head (d4afdd2).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8459      +/-   ##
===========================================
+ Coverage    78.35%   78.38%   +0.03%     
===========================================
  Files         1726     1726              
  Lines       188695   188612      -83     
  Branches     18301    18264      -37     
===========================================
  Hits        147851   147851              
+ Misses       40844    40761      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feliperodri feliperodri added the Code Contracts Function and loop contracts label Sep 17, 2024
@tautschnig tautschnig merged commit f68cf8c into diffblue:develop Sep 17, 2024
40 checks passed
@tautschnig tautschnig deleted the contracts-remove-do-while-0 branch September 17, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants